All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: John Stultz <john.stultz@linaro.org>,
	lkml <linux-kernel@vger.kernel.org>
Cc: Ruchi Kandoi <kandoiruchi@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Oren Laadan <orenl@cellrox.com>, Micha Kalfon <micha@cellrox.com>,
	Rom Lemarchand <romlem@android.com>,
	Android Kernel Team <kernel-team@android.com>
Subject: Re: [RFC][PATCH v2] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack of an arbitrary thread.
Date: Tue, 26 Jan 2016 05:30:00 -0800	[thread overview]
Message-ID: <56A774D8.5020401@linux.intel.com> (raw)
In-Reply-To: <1453782484-3887-1-git-send-email-john.stultz@linaro.org>

On 1/25/2016 8:28 PM, John Stultz wrote:
> From: Ruchi Kandoi <kandoiruchi@google.com>
>
> This allows power/performance management software to set timer
> slack for other threads according to its policy for the thread
> (such as when the thread is designated foreground vs. background
> activity)
>
> Second argument is similar to PR_SET_TIMERSLACK, if non-zero
> then the slack is set to that value otherwise sets it to the
> default for the thread.
>
> Takes PID of the thread as the third argument.
>
> This interface checks that the calling task has permissions to
> to use PTRACE_MODE_ATTACH on the target task, so that we can
> ensure arbitrary apps do not change the timer slack for other
> apps.

Acked-by: Arjan van de Ven <arjan@linux.intel.com>

only slight concern is the locking around the value of the field in the task struct,
but nobody does read-modify-write on it, so they'll get either the new or the old version,
which should be ok.

(until now only the local thread would touch the field, and if you're setting it, by definition
you're not going to sleep yet, so you're not using the field)

  reply	other threads:[~2016-01-26 13:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26  4:28 [RFC][PATCH v2] prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack of an arbitrary thread John Stultz
2016-01-26 13:30 ` Arjan van de Ven [this message]
2016-01-27 11:15   ` Thomas Gleixner
2016-01-27 11:14 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A774D8.5020401@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=john.stultz@linaro.org \
    --cc=kandoiruchi@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=micha@cellrox.com \
    --cc=orenl@cellrox.com \
    --cc=romlem@android.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.