From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: [REGRESSION] component: add support for releasing match data Date: Tue, 26 Jan 2016 14:42:16 +0100 Message-ID: <56A777B8.1020206@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 010F36E5C8 for ; Tue, 26 Jan 2016 05:42:18 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Russell King Cc: Intel Graphics Development , LKML List-Id: intel-gfx@lists.freedesktop.org SGV5LAoKQ29tbWl0IGNlNjU3YjFjZGRmMWY4OGM1NiAoImNvbXBvbmVudDogYWRkIHN1cHBvcnQg Zm9yIHJlbGVhc2luZyBtYXRjaCBkYXRhIikgY2F1c2VzCmEgZ2VuZXJhbCBwcm90ZWN0aW9uIGZh dWx0IHdoZW4gdW5sb2FkaW5nIHNuZC1oZGEtaW50ZWwgd2l0aCB0aGUgaTkxNSBtb2R1bGUgbG9h ZGVkCm9uIGEgcmVjZW50IHNreWxha2UgbWFjaGluZS4KClRoaXMgYnJlYWtzIG9uZSBvZiB0aGUg aTkxNSBhY2NlcHRhbmNlIHRlc3RzIHRoYXQgcGVyZm9ybXMgYSBtb2R1bGUgdW5sb2FkL3JlbG9h ZCBvbgpzbmQtaGRhLWludGVsIGFuZCBpOTE1LgoKIyBtb2Rwcm9iZSAtciBzbmQtaGRhLWludGVs CgpbICAyNjguNjM1NzkyXSBnZW5lcmFsIHByb3RlY3Rpb24gZmF1bHQ6IDAwMDAgWyMxXSBQUkVF TVBUIFNNUCBERUJVR19QQUdFQUxMT0MgClsgIDI2OC42MzU4NzldIE1vZHVsZXMgbGlua2VkIGlu OiBmdXNlIHNuZF9oZGFfY29kZWNfaGRtaSAKc25kX2hkYV9jb2RlY19yZWFsdGVrIHNuZF9oZGFf Y29kZWNfZ2VuZXJpYyBzbmRfaGRhX2ludGVsKC0pIApzbmRfaGRhX2NvZGVjIHNuZF9od2RlcCBz bmRfaGRhX2NvcmUgc25kX3BjbSBzbmRfc2VxX21pZGkgCnNuZF9zZXFfbWlkaV9ldmVudCBzbmRf cmF3bWlkaSBzbmRfc2VxIGlucHV0X2xlZHMgaW50ZWxfcmFwbCBsZWRfY2xhc3MgCng4Nl9wa2df dGVtcF90aGVybWFsIHNuZF9zZXFfZGV2aWNlIHNuZF90aW1lciB0aGVybWFsIGZhbiB3bWkgc25k IApzb3VuZGNvcmUgcGluY3RybF9zdW5yaXNlcG9pbnQgcGluY3RybF9pbnRlbCBhY3BpX2NwdWZy ZXEgYWNwaV9wYWQgaTkxNSAKcHJvY2Vzc29yIHBhcnBvcnRfcGMgcHBkZXYgcGFycG9ydCBlZml2 YXJmcyBhdXRvZnM0ClsgIDI2OC42MzYwNzJdIENQVTogMyBQSUQ6IDIxNTYgQ29tbTogbW9kcHJv YmUgVGFpbnRlZDogRyAgICAgVSAgVyAgICAgICA0LjUuMC1yYzErICM0NjI2ClsgIDI2OC42MzYx MDFdIEhhcmR3YXJlIG5hbWU6IEludGVsIENvcnBvcmF0aW9uIFNreWxha2UgQ2xpZW50IApwbGF0 Zm9ybS9Ta3lsYWtlIERUIEREUjQKWyAgMjY4LjYzNjE0Ml0gdGFzazogZmZmZjg4MDQ0MjQyYWI4 MCB0aTogZmZmZjg4MDA4OWM3YzAwMCB0YXNrLnRpOiBmZmZmODgwMDg5YzdjMDAwClsgIDI2OC42 MzYxNjhdIFJJUDogMDAxMDpbPGZmZmZmZmZmODE0MWY4NjU+XSAgWzxmZmZmZmZmZjgxNDFmODY1 Pl0gZGV2bV9jb21wb25lbnRfbWF0Y2hfcmVsZWFzZSsweDM1LzB4NTAKWyAgMjY4LjYzNjIwNV0g UlNQOiAwMDE4OmZmZmY4ODAwODljN2ZkODggIEVGTEFHUzogMDAwMTAyMDIKWyAgMjY4LjYzNjIy NF0gUkFYOiA2YjZiNmI2YjZiNmI2YjZiIFJCWDogMDAwMDAwMDAwMDAwMDAwMCBSQ1g6IDAwMDAw MDAwMDAwMDAwMDEKWyAgMjY4LjYzNjI0OF0gUkRYOiBmZmZmODgwNDUzYjcxMjYwIFJTSTogNmI2 YjZiNmI2YjZiNmI2YiBSREk6IGZmZmY4ODA0NTkyNTQ1YjgKWyAgMjY4LjYzNjI3Ml0gUkJQOiBm ZmZmODgwMDg5YzdmZGEwIFIwODogZmZmZjg4MDQ1YzAwMzlkMCBSMDk6IDAwMDAwMDAwMDAwMDAw MjYKWyAgMjY4LjYzNjI5Nl0gUjEwOiAwMDAwMDAwMDAwMDAwMGQyIFIxMTogMDAwMDAwMDAwMDAw MmM4MSBSMTI6IGZmZmY4ODA0NTkyNTQ1YjgKWyAgMjY4LjYzNjMyMF0gUjEzOiBmZmZmODgwNDU4 MjE4MWIwIFIxNDogMDAwMDAwMDAwMDAwMDAwMiBSMTU6IGZmZmY4ODAwODljN2ZkZDAKWyAgMjY4 LjYzNjM0NV0gRlM6ICAwMDAwN2ZjM2I2Zjc0NzAwKDAwMDApIEdTOmZmZmY4ODA0NmM2YzAwMDAo MDAwMCkga25sR1M6MDAwMDAwMDAwMDAwMDAwMApbICAyNjguNjM2MzczXSBDUzogIDAwMTAgRFM6 IDAwMDAgRVM6IDAwMDAgQ1IwOiAwMDAwMDAwMDgwMDUwMDMzClsgIDI2OC42MzYzOTNdIENSMjog MDAwMDU1OWRhZTliMTBlMCBDUjM6IDAwMDAwMDA0NTU2NmUwMDAgQ1I0OiAwMDAwMDAwMDAwMzQw NmUwClsgIDI2OC42MzY0MTddIERSMDogMDAwMDAwMDAwMDAwMDAwMCBEUjE6IDAwMDAwMDAwMDAw MDAwMDAgRFIyOiAwMDAwMDAwMDAwMDAwMDAwClsgIDI2OC42MzY0NDJdIERSMzogMDAwMDAwMDAw MDAwMDAwMCBEUjY6IDAwMDAwMDAwZmZmZTBmZjAgRFI3OiAwMDAwMDAwMDAwMDAwNDAwClsgIDI2 OC42MzY0NjhdIFN0YWNrOgpbICAyNjguNjM2NDc3XSAgZmZmZjg4MDQ1ODIxODE4OCBmZmZmODgw NDU5MjU0NWI4IGZmZmY4ODAwODljN2ZkZDAgZmZmZjg4MDA4OWM3ZmUwOApbICAyNjguNjM2NTA5 XSAgZmZmZmZmZmY4MTQyOGY1MCAwMDAwMDAwMDAwMDAwMjg2IGZmZmY4ODA0NTkyNTQ4MTggZmZm ZmZmZmYwMDAwMDAwMApbICAyNjguNjM2NTQyXSAgZmZmZjg4MDQ1OTI1NDgxOCBmZmZmODgwNDU4 MjE4MTg4IGZmZmY4ODA0NTNiNzEyMzggZmZmZjg4MDQ1OTI1NDViOApbICAyNjguNjM2NTc0XSBD YWxsIFRyYWNlOgpbICAyNjguNjM2NTg3XSAgWzxmZmZmZmZmZjgxNDI4ZjUwPl0gcmVsZWFzZV9u b2RlcysweDEyMC8weDFlMApbICAyNjguNjM2NjA4XSAgWzxmZmZmZmZmZjgxNDI5MTA3Pl0gZGV2 cmVzX3JlbGVhc2VfYWxsKzB4MzcvMHg2MApbICAyNjguNjM2NjMwXSAgWzxmZmZmZmZmZjgxNDI0 Yzc0Pl0gX19kZXZpY2VfcmVsZWFzZV9kcml2ZXIrMHhhNC8weDE1MApbICAyNjguNjM2NjU0XSAg WzxmZmZmZmZmZjgxNDI1NjFjPl0gZHJpdmVyX2RldGFjaCsweGFjLzB4YjAKWyAgMjY4LjYzNjY3 NF0gIFs8ZmZmZmZmZmY4MTQyNDdhMD5dIGJ1c19yZW1vdmVfZHJpdmVyKzB4NjAvMHhiMApbICAy NjguNjM2Njk1XSAgWzxmZmZmZmZmZjgxNDI1YmY3Pl0gZHJpdmVyX3VucmVnaXN0ZXIrMHgyNy8w eDUwClsgIDI2OC42MzY3MTddICBbPGZmZmZmZmZmODEzMjA1MzU+XSBwY2lfdW5yZWdpc3Rlcl9k cml2ZXIrMHgyNS8weDcwClsgIDI2OC42MzY3NDBdICBbPGZmZmZmZmZmYzAyMmE5YTE+XSBhenhf ZHJpdmVyX2V4aXQrMHgxMC8weDY2ZiBbc25kX2hkYV9pbnRlbF0KWyAgMjY4LjYzNjc2N10gIFs8 ZmZmZmZmZmY4MTBmNDQ1Yj5dIFN5U19kZWxldGVfbW9kdWxlKzB4MTdiLzB4MjQwClsgIDI2OC42 MzY3ODldICBbPGZmZmZmZmZmODE3Mzk2ZDc+XSBlbnRyeV9TWVNDQUxMXzY0X2Zhc3RwYXRoKzB4 MTIvMHg2YQpbICAyNjguNjM2ODExXSBDb2RlOiBmNSA0MSA1NCA0OSA4OSBmYyA1MyAzMSBkYiA0 OCA4MyA3ZSAwOCAwMCA3NCAyOSA0OCAKOGQgMTQgODAgNDkgOGIgNDUgMTAgNDggOGQgMTQgZDAg NDggOGIgNDIgMTAgNDggODUgYzAgNzQgMDggNDggOGIgMzIgNGMgCjg5IGU3IDxmZj4gZDAgOGQg NDMgMDEgNDkgM2IgNDUgMDggNDggODkgYzMgNzIgZDcgNWIgNDEgNWMgNDEgNWQgCjVkIGMzIApb ICAyNjguNjM2OTkzXSBSSVAgIFs8ZmZmZmZmZmY4MTQxZjg2NT5dIGRldm1fY29tcG9uZW50X21h dGNoX3JlbGVhc2UrMHgzNS8weDUwClsgIDI2OC42MzcwMjFdICBSU1AgPGZmZmY4ODAwODljN2Zk ODg+ClsgIDI2OC42MzcwNDNdIC0tLVsgZW5kIHRyYWNlIDMxNzMxZGZjOWQ5NTU2MmIgXS0tLQoK TG9va2luZyBhdCB0aGUgY29kZSwgSSBzZWUgaXQgb25seSBoYXBwZW5zIG9uIG5ld2VyIGk5MTUg Y2hpcHMgd2l0aCBwb3dlciB3ZWxsIHN1cHBvcnQsCnNvIGhhc3dlbGwvYnJvYWR3ZWxsL3NreWxh a2UgYXJlIHByb2JhYmx5IGFmZmVjdGVkIGluIHRoZSBmdW5jdGlvbnMKc25kX2hkYWNfaTkxNV9p bml0IGFuZCBzbmRfaGRhY19pOTE1X2V4aXQuCgp+TWFhcnRlbgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965936AbcAZNmX (ORCPT ); Tue, 26 Jan 2016 08:42:23 -0500 Received: from mga04.intel.com ([192.55.52.120]:40948 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965242AbcAZNmT (ORCPT ); Tue, 26 Jan 2016 08:42:19 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,350,1449561600"; d="scan'208";a="734481920" To: Russell King From: Maarten Lankhorst Subject: [REGRESSION] component: add support for releasing match data Cc: LKML , Intel Graphics Development Message-ID: <56A777B8.1020206@linux.intel.com> Date: Tue, 26 Jan 2016 14:42:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey, Commit ce657b1cddf1f88c56 ("component: add support for releasing match data") causes a general protection fault when unloading snd-hda-intel with the i915 module loaded on a recent skylake machine. This breaks one of the i915 acceptance tests that performs a module unload/reload on snd-hda-intel and i915. # modprobe -r snd-hda-intel [ 268.635792] general protection fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC [ 268.635879] Modules linked in: fuse snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel(-) snd_hda_codec snd_hwdep snd_hda_core snd_pcm snd_seq_midi snd_seq_midi_event snd_rawmidi snd_seq input_leds intel_rapl led_class x86_pkg_temp_thermal snd_seq_device snd_timer thermal fan wmi snd soundcore pinctrl_sunrisepoint pinctrl_intel acpi_cpufreq acpi_pad i915 processor parport_pc ppdev parport efivarfs autofs4 [ 268.636072] CPU: 3 PID: 2156 Comm: modprobe Tainted: G U W 4.5.0-rc1+ #4626 [ 268.636101] Hardware name: Intel Corporation Skylake Client platform/Skylake DT DDR4 [ 268.636142] task: ffff88044242ab80 ti: ffff880089c7c000 task.ti: ffff880089c7c000 [ 268.636168] RIP: 0010:[] [] devm_component_match_release+0x35/0x50 [ 268.636205] RSP: 0018:ffff880089c7fd88 EFLAGS: 00010202 [ 268.636224] RAX: 6b6b6b6b6b6b6b6b RBX: 0000000000000000 RCX: 0000000000000001 [ 268.636248] RDX: ffff880453b71260 RSI: 6b6b6b6b6b6b6b6b RDI: ffff8804592545b8 [ 268.636272] RBP: ffff880089c7fda0 R08: ffff88045c0039d0 R09: 0000000000000026 [ 268.636296] R10: 00000000000000d2 R11: 0000000000002c81 R12: ffff8804592545b8 [ 268.636320] R13: ffff8804582181b0 R14: 0000000000000002 R15: ffff880089c7fdd0 [ 268.636345] FS: 00007fc3b6f74700(0000) GS:ffff88046c6c0000(0000) knlGS:0000000000000000 [ 268.636373] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 268.636393] CR2: 0000559dae9b10e0 CR3: 000000045566e000 CR4: 00000000003406e0 [ 268.636417] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 268.636442] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 268.636468] Stack: [ 268.636477] ffff880458218188 ffff8804592545b8 ffff880089c7fdd0 ffff880089c7fe08 [ 268.636509] ffffffff81428f50 0000000000000286 ffff880459254818 ffffffff00000000 [ 268.636542] ffff880459254818 ffff880458218188 ffff880453b71238 ffff8804592545b8 [ 268.636574] Call Trace: [ 268.636587] [] release_nodes+0x120/0x1e0 [ 268.636608] [] devres_release_all+0x37/0x60 [ 268.636630] [] __device_release_driver+0xa4/0x150 [ 268.636654] [] driver_detach+0xac/0xb0 [ 268.636674] [] bus_remove_driver+0x60/0xb0 [ 268.636695] [] driver_unregister+0x27/0x50 [ 268.636717] [] pci_unregister_driver+0x25/0x70 [ 268.636740] [] azx_driver_exit+0x10/0x66f [snd_hda_intel] [ 268.636767] [] SyS_delete_module+0x17b/0x240 [ 268.636789] [] entry_SYSCALL_64_fastpath+0x12/0x6a [ 268.636811] Code: f5 41 54 49 89 fc 53 31 db 48 83 7e 08 00 74 29 48 8d 14 80 49 8b 45 10 48 8d 14 d0 48 8b 42 10 48 85 c0 74 08 48 8b 32 4c 89 e7 d0 8d 43 01 49 3b 45 08 48 89 c3 72 d7 5b 41 5c 41 5d 5d c3 [ 268.636993] RIP [] devm_component_match_release+0x35/0x50 [ 268.637021] RSP [ 268.637043] ---[ end trace 31731dfc9d95562b ]--- Looking at the code, I see it only happens on newer i915 chips with power well support, so haswell/broadwell/skylake are probably affected in the functions snd_hdac_i915_init and snd_hdac_i915_exit. ~Maarten