From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO4wB-0006E2-C4 for qemu-devel@nongnu.org; Tue, 26 Jan 2016 09:49:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO4w8-0007Lw-2w for qemu-devel@nongnu.org; Tue, 26 Jan 2016 09:49:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO4w7-0007Lp-TW for qemu-devel@nongnu.org; Tue, 26 Jan 2016 09:49:40 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id DDC7AA3815 for ; Tue, 26 Jan 2016 14:49:38 +0000 (UTC) References: <1453564933-29638-1-git-send-email-ehabkost@redhat.com> <56A606B3.7050400@redhat.com> <20160126111522.00c3c395@nial.brq.redhat.com> From: Laszlo Ersek Message-ID: <56A7877F.4040501@redhat.com> Date: Tue, 26 Jan 2016 15:49:35 +0100 MIME-Version: 1.0 In-Reply-To: <20160126111522.00c3c395@nial.brq.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , Markus Armbruster , qemu-devel@nongnu.org, Paolo Bonzini , John Snow On 01/26/16 11:15, Igor Mammedov wrote: > On Mon, 25 Jan 2016 12:27:47 +0100 > Laszlo Ersek wrote: > >> On 01/23/16 17:02, Eduardo Habkost wrote: >>> This is another attempt to remove old q35 machine code. Now I am >>> also removing unused compat code to demonstrate the benefit of >>> throwing away the old code that nobody uses. >>> >>> Eduardo Habkost (5): >>> q35: Remove old machine versions >>> machine: Remove no_tco field >>> ich9: Remove enable_tco arguments from init functions >>> q35: Remove unused q35-acpi-dsdt.aml file >>> q35: No need to check gigabyte_align >>> >>> Makefile | 2 +- >>> hw/acpi/ich9.c | 8 +-- >>> hw/i386/pc_q35.c | 176 +--------------------------------------------- >>> hw/isa/lpc_ich9.c | 4 +- >>> include/hw/acpi/ich9.h | 1 - >>> include/hw/boards.h | 1 - >>> include/hw/i386/ich9.h | 2 +- >>> pc-bios/q35-acpi-dsdt.aml | Bin 7344 -> 0 bytes >>> 8 files changed, 9 insertions(+), 185 deletions(-) >>> delete mode 100644 pc-bios/q35-acpi-dsdt.aml >>> >> >> I read / skimmed the earlier discussion: >> >> http://thread.gmane.org/gmane.comp.emulators.qemu/356340 >> http://thread.gmane.org/gmane.comp.emulators.qemu/382574 >> >> For patches 1, 2, 3, 5: >> >> Reviewed-by: Laszlo Ersek >> >> For patch 4: >> >> How about removing the following two files in addition: >> - hw/i386/q35-acpi-dsdt.dsl >> - hw/i386/q35-acpi-dsdt.hex.generated > above files don't exist in current master as there where removed > by DSDT->AML conversion series. Sigh. That's right. For some reason I looked at a wrong branch in my tree. For patch 4 too: Reviewed-by: Laszlo Ersek > And well, they weren't related > to legacy code removed here anyway. Sigh again. You are right. "pc-bios/q35-acpi-dsdt.aml" came from SeaBIOS's "src/fw/q35-acpi-dsdt.dsl", apparently, *not* from QEMU's "hw/i386/q35-acpi-dsdt.dsl" It's just great that up to 9fc6502606, QEMU and SeaBIOS had had an independent, but identically named (and more or less same purpose) file! >> and updating the references in "hw/i386/Makefile.objs"? >> >> Thanks >> Laszlo >