From: Guenter Roeck <linux@roeck-us.net>
To: William Breathitt Gray <vilhelm.gray@gmail.com>, wim@iguana.be
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] watchdog: Add watchdog timer support for the WinSystems EBC-C384
Date: Tue, 26 Jan 2016 07:30:22 -0800 [thread overview]
Message-ID: <56A7910E.2040808@roeck-us.net> (raw)
In-Reply-To: <20160126143106.GA5539@sophia>
On 01/26/2016 06:31 AM, William Breathitt Gray wrote:
> On 01/25/2016 5:11 PM, Guenter Roeck wrote:
>>> + dev_warn(dev, "Invalid timeout (%u seconds), using default (%u seconds)\n",
>>> + timeout, WATCHDOG_TIMEOUT);
>>
>> Multi-line alignment is off by one character.
>
> I used tabs to align the lines to 8-character boundaries. Should I add
> an additional space to align the "timeout" argument with the "dev"
> argument?
>
Continuation line alignment should be with "(", so, yes, on the same column as "dev".
Thanks,
Guenter
next prev parent reply other threads:[~2016-01-26 15:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 14:31 [PATCH v3] watchdog: Add watchdog timer support for the WinSystems EBC-C384 William Breathitt Gray
2016-01-26 15:30 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-25 19:09 William Breathitt Gray
2016-01-25 19:28 ` One Thousand Gnomes
2016-01-25 20:42 ` Guenter Roeck
2016-01-25 23:36 ` William Breathitt Gray
2016-01-26 1:26 ` Guenter Roeck
2016-01-26 23:38 ` William Breathitt Gray
2016-01-27 5:02 ` Guenter Roeck
2016-01-28 0:18 ` William Breathitt Gray
2016-01-28 1:51 ` Guenter Roeck
2016-01-28 11:05 ` One Thousand Gnomes
2016-01-28 11:05 ` One Thousand Gnomes
2016-01-26 1:58 ` Guenter Roeck
2016-02-28 14:07 ` Wim Van Sebroeck
2016-02-28 14:36 ` William Breathitt Gray
2016-02-28 15:02 ` Guenter Roeck
2016-02-28 16:24 ` Wim Van Sebroeck
2016-01-26 1:11 ` Guenter Roeck
2016-01-26 9:09 ` Paul Bolle
2016-01-26 12:33 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A7910E.2040808@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=vilhelm.gray@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.