From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO69V-0002ly-VL for qemu-devel@nongnu.org; Tue, 26 Jan 2016 11:07:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO69Q-0004Ps-8E for qemu-devel@nongnu.org; Tue, 26 Jan 2016 11:07:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO69Q-0004Po-1Y for qemu-devel@nongnu.org; Tue, 26 Jan 2016 11:07:28 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id B2A3491D2C for ; Tue, 26 Jan 2016 16:07:27 +0000 (UTC) References: <1453817255-10287-1-git-send-email-kraxel@redhat.com> <1453817255-10287-2-git-send-email-kraxel@redhat.com> From: Eric Blake Message-ID: <56A799BE.1080405@redhat.com> Date: Tue, 26 Jan 2016 09:07:26 -0700 MIME-Version: 1.0 In-Reply-To: <1453817255-10287-2-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EFPnSxgcmL82Pk6vF9Dc1Tt3Vx0fvcvAx" Subject: Re: [Qemu-devel] [PATCH v2 2/5] qapi: switch x-input-send-event from console to device+head List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: Marcelo Tosatti , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EFPnSxgcmL82Pk6vF9Dc1Tt3Vx0fvcvAx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2016 07:07 AM, Gerd Hoffmann wrote: > Use display device qdev id and head number instead of console index to > specify the QemuConsole. This makes things consistent with input > devices (for input routing) and vnc server configuration, which both us= e > display and head too. >=20 > Signed-off-by: Gerd Hoffmann > Reviewed-by: Daniel P. Berrange > --- > qapi-schema.json | 32 +++++++++++++++++--------------- > qmp-commands.hx | 17 +++++++++-------- > ui/input.c | 15 ++++++++++----- > 3 files changed, 36 insertions(+), 28 deletions(-) >=20 Might be worth a mention in the commit message that the change is acceptable because it is to an 'x-' command (and that a later patch will rename the command). Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EFPnSxgcmL82Pk6vF9Dc1Tt3Vx0fvcvAx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWp5m+AAoJEKeha0olJ0NqjK8IAK+Z9S1WA1rpZg4iPTVyIay7 FFeiEYgrgwwQHwnEdV0BUx2vjNY9v9EdFSrfxynM7GNBqjmWP5qAyYmglTaxt3em OX9B6T5n47nAfrUCVcWd33vVVe5AOH2xrJ8z0glKk8PcJKBcVaOqwLP5P32MB55X 3bV+jSLLN5D2ZJya7ETxTiERosrMZQDmZyZshYhnO9L4bUQoRw2BgNoTmu+y7wSQ zpYikpdORO3BEsVPWVv6/wBnAqgncBEx8o2iF8rkdq5dxWu8PmUvSGzbIETiUVQw ki/eH5FnfM8yAY8ylok2JV5K5QXjIGhiVIrC+4CtnxxcKL0esWkI/ht2rX8p8dY= =kC66 -----END PGP SIGNATURE----- --EFPnSxgcmL82Pk6vF9Dc1Tt3Vx0fvcvAx--