From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [REGRESSION] component: add support for releasing match data Date: Tue, 26 Jan 2016 17:21:06 +0100 Message-ID: <56A79CF2.4010200@linux.intel.com> References: <56A777B8.1020206@linux.intel.com> <20160126141504.GO10826@n2100.arm.linux.org.uk> <56A78292.7010009@linux.intel.com> <20160126144856.GQ10826@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C6496E255 for ; Tue, 26 Jan 2016 08:21:12 -0800 (PST) In-Reply-To: <20160126144856.GQ10826@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Russell King - ARM Linux Cc: Intel Graphics Development , LKML List-Id: intel-gfx@lists.freedesktop.org T3AgMjYtMDEtMTYgb20gMTU6NDggc2NocmVlZiBSdXNzZWxsIEtpbmcgLSBBUk0gTGludXg6Cj4g T24gVHVlLCBKYW4gMjYsIDIwMTYgYXQgMDM6Mjg6MzRQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4+IFNvbWV0aGluZyBzaW1pbGFyIHRvIGEgc2VnZmF1bHQuIEl0J3MgdHJ5aW5n IHRvIGNhbGwgMHg2YjZiNmI2YjZiIHdoaWNoCj4+IGlzIFBPSVNPTl9GUkVFLgo+Pgo+PiBtYyBh cHBlYXJzIHRvIGJlIGZyZWVkIGFscmVhZHksIHNvIGNhbGxpbmcgbWMtPnJlbGVhc2Ugd291bGQg anVtcCB0bwo+PiBpbnZhbGlkIGRhdGEuCj4gSXQgc2VlbXMgdGhhdCBteSBkZXZtIGZvbyB3YXNu J3QgcXVpdGUgdXAgdG8gc2NyYXRjaC4gIFF1aXRlIHdoeSBpdAo+IGRvZXNuJ3Qgc2hvdyBoZXJl IHdoaWxlIHRlc3RpbmcgaXQgKEkgaGF2ZSBwYXRjaGVzIGZvciB0aGUgZXRuYXZpdgo+IEdQVSBk cml2ZXIsIHdoaWNoIEknbSByZWd1bGFybHkgaW5zZXJ0aW5nL3JlbW92aW5nKSBJJ20gbm90IHN1 cmUuCj4KPiBQbGVhc2UgdGVzdCB0aGlzIHBhdGNoIC0gaXQgc2VlbXMgIm5vIHdvcnNlIiBmb3Ig bWUgKGluIHRoYXQgaXQgZGlkbid0Cj4gY3Jhc2ggYmVmb3JlLCBhbmQgaXQgc3RpbGwgZG9lc24n dCBjcmFzaC4pClRoYXQgb25lIHdvcmtzLCB0aGFua3MuIDopCgp+TWFhcnRlbgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966591AbcAZQVO (ORCPT ); Tue, 26 Jan 2016 11:21:14 -0500 Received: from mga02.intel.com ([134.134.136.20]:43258 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965442AbcAZQVM (ORCPT ); Tue, 26 Jan 2016 11:21:12 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,350,1449561600"; d="scan'208";a="641691918" Subject: Re: [REGRESSION] component: add support for releasing match data To: Russell King - ARM Linux References: <56A777B8.1020206@linux.intel.com> <20160126141504.GO10826@n2100.arm.linux.org.uk> <56A78292.7010009@linux.intel.com> <20160126144856.GQ10826@n2100.arm.linux.org.uk> Cc: LKML , Intel Graphics Development From: Maarten Lankhorst Message-ID: <56A79CF2.4010200@linux.intel.com> Date: Tue, 26 Jan 2016 17:21:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160126144856.GQ10826@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 26-01-16 om 15:48 schreef Russell King - ARM Linux: > On Tue, Jan 26, 2016 at 03:28:34PM +0100, Maarten Lankhorst wrote: >> Something similar to a segfault. It's trying to call 0x6b6b6b6b6b which >> is POISON_FREE. >> >> mc appears to be freed already, so calling mc->release would jump to >> invalid data. > It seems that my devm foo wasn't quite up to scratch. Quite why it > doesn't show here while testing it (I have patches for the etnaviv > GPU driver, which I'm regularly inserting/removing) I'm not sure. > > Please test this patch - it seems "no worse" for me (in that it didn't > crash before, and it still doesn't crash.) That one works, thanks. :) ~Maarten