From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO6y1-00013d-EC for qemu-devel@nongnu.org; Tue, 26 Jan 2016 11:59:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO6xw-000085-3m for qemu-devel@nongnu.org; Tue, 26 Jan 2016 11:59:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO6xv-000081-UX for qemu-devel@nongnu.org; Tue, 26 Jan 2016 11:59:40 -0500 References: <1453790613-8308-1-git-send-email-zhang.zhanghailiang@huawei.com> From: Eric Blake Message-ID: <56A7A5FA.9020406@redhat.com> Date: Tue, 26 Jan 2016 09:59:38 -0700 MIME-Version: 1.0 In-Reply-To: <1453790613-8308-1-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9nb2RCNI4ESa3hKTElAcD6k1mMSfcdF5x" Subject: Re: [Qemu-devel] [PATCH v2] net/filter: Fix the output information for command 'info network' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: Jason Wang , Markus Armbruster , Yang Hongyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9nb2RCNI4ESa3hKTElAcD6k1mMSfcdF5x Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/25/2016 11:43 PM, zhanghailiang wrote: > The properties of netfilter object could be changed by 'qom-set' > command, but the output of 'info network' command is not updated, > because it got the old information through nf->info_str, it will > not be updated while we change the value of netfilter's property. >=20 > Here we split a helper function that could collect the output > information for filter, and also remove the useless member > 'info_str' from struct NetFilterState. >=20 > Signed-off-by: zhanghailiang > Cc: Jason Wang > Cc: Eric Blake > Cc: Markus Armbruster > Cc: Yang Hongyang > --- > v2: > - write the information to monitor directly instead of > printing into a temporary string before output them. (Eric's comment)= Looks a lot nicer compared to v1! Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9nb2RCNI4ESa3hKTElAcD6k1mMSfcdF5x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWp6X6AAoJEKeha0olJ0Nqyc4IAK2Q+EMuQOTv7VmztlJLwSO8 NSQUTY4yhwX3YNVqeNVyBXDkyMrGJ8VIpQ7H3pGBdE9bGbc5fXjZ02MdOCr5ENku SxLFvKbMcgSuAYMlKldUIIUSjOFTS5lBhYLmSP+CLiuFx/H6IJmycmJ+8fEOHIT+ cODetMD/sUh94WB68gRfui2GyHlpNTYyqiI7HEGzBb2mZ8mY0keoZO90KwN+Ac/J 0NZR+fOB6/G1GuBQhudI6PbB5LZj9CV8XOcYT0QpRhUqEWyQIG/zPATKSaFLf8PI zWDLkgrTn2ydPAUHD09b9bWVf/YkYGqsY0BuvdY5582Num0YtwGvXDrb+zl9qZY= =StAX -----END PGP SIGNATURE----- --9nb2RCNI4ESa3hKTElAcD6k1mMSfcdF5x--