From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO7v0-00056d-Pv for qemu-devel@nongnu.org; Tue, 26 Jan 2016 13:00:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO7uv-0005vW-I6 for qemu-devel@nongnu.org; Tue, 26 Jan 2016 13:00:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO7uv-0005us-B7 for qemu-devel@nongnu.org; Tue, 26 Jan 2016 13:00:37 -0500 References: <1453824953-27230-1-git-send-email-pbonzini@redhat.com> <20160126182054-mutt-send-email-mst@redhat.com> <56A7B36E.9070409@mvista.com> From: Paolo Bonzini Message-ID: <56A7B43C.2090201@redhat.com> Date: Tue, 26 Jan 2016 19:00:28 +0100 MIME-Version: 1.0 In-Reply-To: <56A7B36E.9070409@mvista.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ipmi: do not take/drop iothread lock List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Minyard , "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 26/01/2016 18:57, Corey Minyard wrote: > On 01/26/2016 10:21 AM, Michael S. Tsirkin wrote: >> On Tue, Jan 26, 2016 at 05:15:53PM +0100, Paolo Bonzini wrote: >>> This is not necessary and actually causes a hang; it was probably copied >>> and pasted from KVM code, that is one of the very few places that run >>> outside iothread lock. >>> >>> Signed-off-by: Paolo Bonzini >> Makes sense. I wonder how hard would it be to have a test to catch this. > > The IPMI side would be easy for me, but I don't know how to handle > catching the NMI. I'm afraid there's no way to trap an NMI from qtest. Paolo