From: Andrei Borzenkov <arvidjaar@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: New module for android bootimg filesystem
Date: Tue, 26 Jan 2016 21:26:26 +0300 [thread overview]
Message-ID: <56A7BA52.8070103@gmail.com> (raw)
In-Reply-To: <5a54589b028c738597d8eed153db0964@shealevy.com>
26.01.2016 21:11, Shea Levy пишет:
> Hello all,
>
> On the android-bootimg branch of my github fork [1], I've implemented
> initial support for the android bootimg format[2]. Currently the kernel
> and ramdisk are accessible on the filesystem; future work may include
> exporting the kernel command line, expected memory offsets, etc. somehow
> (perhaps in a file that sets some grub variables that is meant to be
> source'd). The developer's manual doesn't mention how to submit changes
> using git; should I squash this all down into one commit, send a patch
> per commit, or something else?
>
There are no special rules. Both ten thousand lines single patch and ten
thousand single liners are silly. So just submit it as you see
appropriate and let discuss it. If possible, it is of course better to
squash technical commits that do not convey any information but that is
commonplace.
> Thanks,
> Shea
>
> [1]: https://github.com/shlevy/grub/tree/android-bootimg
> [2]:
> https://android.googlesource.com/platform/system/core/+/506d233e7ac8ca4efa80768153d842c296477f99/mkbootimg/bootimg.h
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2016-01-26 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 18:11 New module for android bootimg filesystem Shea Levy
2016-01-26 18:26 ` Andrei Borzenkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A7BA52.8070103@gmail.com \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.