From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aODDX-00012u-RZ for qemu-devel@nongnu.org; Tue, 26 Jan 2016 18:40:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aODDS-0007VT-T2 for qemu-devel@nongnu.org; Tue, 26 Jan 2016 18:40:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aODDS-0007Uk-N5 for qemu-devel@nongnu.org; Tue, 26 Jan 2016 18:40:06 -0500 References: <1453219845-30939-1-git-send-email-eblake@redhat.com> <1453219845-30939-8-git-send-email-eblake@redhat.com> <87y4bks2g7.fsf@blackfin.pond.sub.org> <569FBF7B.6090408@redhat.com> From: Eric Blake Message-ID: <56A803D5.1040506@redhat.com> Date: Tue, 26 Jan 2016 16:40:05 -0700 MIME-Version: 1.0 In-Reply-To: <569FBF7B.6090408@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mn1Rfi3oIiJQxRubcvSdQC7HAMNnEj6uQ" Subject: Re: [Qemu-devel] [PATCH v9 07/37] qapi: Improve generated event use of qapi visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mn1Rfi3oIiJQxRubcvSdQC7HAMNnEj6uQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/20/2016 10:10 AM, Eric Blake wrote: > Oops. It all gets cleaned up in 33 when visit_end_struct() loses the > errp argument, but in the meantime, I think the most robust way to writ= e > this would be: >=20 > out_obj: > visit_end_struct(v, err ? NULL : &err); > if (err) { > ... >=20 >> >> I guess the idea is to go from gen_visit_fields() failure through >> visit_end_struct() here to out. Correct? >=20 > Yes. Technically, visit_end_struct() for QMP output visitor never sets errp, but it's not nice to have to audit multiple files just to find that out. I'll stick to the ternary until patch 33 cleans it back up. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mn1Rfi3oIiJQxRubcvSdQC7HAMNnEj6uQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWqAPVAAoJEKeha0olJ0Nq3Y8IAK5P+UpBgzuilziLgfRc2rBs XhOg99+axDrJuLl5HAIdCa+bIMT+dTWcq3/xPk/H5smVGQHvBA8T3VVs42zcAuRL soTVgbHYTeiD8b56UOayIv0XIUnAMikcS8EyypMw7+K8PToMSWXcb3SkZK/JBUVm h9noYycSxp6L5ayB6M5svj4WJcwbPpIA2WP3PRhqwKv4yj35fcCi26z/E/2hJZVX KJRIeZ45GBPFHF7wW++H3eBnJLBw7s15yf1+J6h/qYlceiw3qwBsLDgFHX/xlg4h nlJPwXUCx+GmZwXSEEUXw3NEXuUJG1KrvwVws2Jx1RjnCFbwiK86TilgUCjHkGw= =bfhL -----END PGP SIGNATURE----- --mn1Rfi3oIiJQxRubcvSdQC7HAMNnEj6uQ--