From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: Brian Norris <computersforpeace@gmail.com>,
<linux-mtd@lists.infradead.org>
Subject: Re: [mtd-utils PATCH] Makefile: install: don't look for scripts in BUILDDIR
Date: Wed, 27 Jan 2016 08:42:38 +0800 [thread overview]
Message-ID: <56A8127E.1060808@cn.fujitsu.com> (raw)
In-Reply-To: <1453844216-133634-1-git-send-email-computersforpeace@gmail.com>
On 01/27/2016 05:36 AM, Brian Norris wrote:
> Our ${SCRIPTS} (e.g., flash_eraseall) are not found in the build
> directory; they should be found in their original location.
>
> This fixes a typo in the Makefile refactoring, which caused 'make
> install' to fail with messages like:
Ooooops, yes, it's my typo. Sorry for that.
Reviewed-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Thanx
Yang
>
> make: *** No rule to make target '[...my source-build directory...]/armv7a-cros-linux-gnueabi/misc-utils/flash_eraseall'. Stop.
>
> because the install target is looking in the wrong place for
> flash_eraseall.
>
> Fixes: 7d81790ced34 ("mtd-utils: Restructure the mtd-utils source.")
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index bd9504ae72f0..977c9c5056ed 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -67,7 +67,7 @@ endif
> rm -f $(BUILDDIR)/include/version.h
> $(MAKE) -C $(TESTS) clean
>
> -install:: $(addprefix $(BUILDDIR)/,${BINS} ${SCRIPTS})
> +install:: $(addprefix $(BUILDDIR)/,${BINS}) ${SCRIPTS}
> mkdir -p ${DESTDIR}/${SBINDIR}
> install -m 0755 $^ ${DESTDIR}/${SBINDIR}/
> mkdir -p ${DESTDIR}/${MANDIR}/man1
>
next prev parent reply other threads:[~2016-01-27 0:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 21:36 [mtd-utils PATCH] Makefile: install: don't look for scripts in BUILDDIR Brian Norris
2016-01-27 0:42 ` Dongsheng Yang [this message]
2016-01-27 1:06 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A8127E.1060808@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.