From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOEdu-00063i-Ox for qemu-devel@nongnu.org; Tue, 26 Jan 2016 20:11:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOEdr-0001fT-Ai for qemu-devel@nongnu.org; Tue, 26 Jan 2016 20:11:30 -0500 Received: from mail-pa0-x244.google.com ([2607:f8b0:400e:c03::244]:32890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOEdr-0001ey-3l for qemu-devel@nongnu.org; Tue, 26 Jan 2016 20:11:27 -0500 Received: by mail-pa0-x244.google.com with SMTP id pv5so8510861pac.0 for ; Tue, 26 Jan 2016 17:11:25 -0800 (PST) References: <1452104533-8516-1-git-send-email-mark.cave-ayland@ilande.co.uk> <1452104533-8516-4-git-send-email-mark.cave-ayland@ilande.co.uk> <568F1F0C.6050501@ozlabs.ru> <56A67171.7010004@suse.de> From: Alexey Kardashevskiy Message-ID: <56A81919.2050807@ozlabs.ru> Date: Wed, 27 Jan 2016 12:10:49 +1100 MIME-Version: 1.0 In-Reply-To: <56A67171.7010004@suse.de> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] target-ppc: add CPU access_type into the migration stream List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, quintela@redhat.com, amit.shah@redhat.com On 01/26/2016 06:03 AM, Alexander Graf wrote: > > > On 01/08/2016 03:29 AM, Alexey Kardashevskiy wrote: >> On 01/07/2016 05:22 AM, Mark Cave-Ayland wrote: >>> This is referenced in cpu_ppc_handle_mmu_fault() and so should be included >>> in the migration stream. >>> >>> Signed-off-by: Mark Cave-Ayland >>> --- >>> target-ppc/machine.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/target-ppc/machine.c b/target-ppc/machine.c >>> index 322ce84..cb56423 100644 >>> --- a/target-ppc/machine.c >>> +++ b/target-ppc/machine.c >>> @@ -530,7 +530,7 @@ const VMStateDescription vmstate_ppc_cpu = { >>> >>> /* Internal state */ >>> VMSTATE_UINTTL(env.hflags_nmsr, PowerPCCPU), >>> - /* FIXME: access_type? */ >>> + VMSTATE_INT32(env.access_type, PowerPCCPU), >> >> >> VMSTATE_INT32_V and you need to change access_type's type from "int" to >> "int32_t" (or better use "uint8_t" as it is a simple enum with 3 possible >> values). > > I don't think uint8_t is going to be safe, since vmstate works with > pointers internally and the cast would only migrate the first *byte* of the > value (so the highest byte on BE). I meant that both env.access_type _and_ VMSTATE_INT32 should be changed to uint8_t and VMSTATE_UINT8. -- Alexey