From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752447AbcA0CjD (ORCPT ); Tue, 26 Jan 2016 21:39:03 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:54859 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458AbcA0Ci7 (ORCPT ); Tue, 26 Jan 2016 21:38:59 -0500 Message-ID: <56A82D46.8050604@huawei.com> Date: Wed, 27 Jan 2016 10:36:54 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: Alexei Starovoitov , Brendan Gregg , Daniel Borkmann , "David S. Miller" , He Kuang , Jiri Olsa , Li Zefan , Masami Hiramatsu , Namhyung Kim , "Peter Zijlstra" , , Will Deacon , Subject: Re: [PATCH 05/54] perf build: Use feature dump file for build-test References: <1453715801-7732-1-git-send-email-wangnan0@huawei.com> <1453715801-7732-6-git-send-email-wangnan0@huawei.com> <20160126165945.GC3493@redhat.com> In-Reply-To: <20160126165945.GC3493@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.56A82D62.0041,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 29af67cc8d545bcc7af9fbc132ee8245 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/27 0:59, Arnaldo Carvalho de Melo wrote: > Em Mon, Jan 25, 2016 at 09:55:52AM +0000, Wang Nan escreveu: >> To prevent feature check run too many times, this patch utilizes >> previous introduced feature-dump make target and FEATURES_DUMP >> variable, makes sure the feature checkers run only once when doing >> build-test for normal test cases. >> >> Signed-off-by: Wang Nan >> Cc: Jiri Olsa >> Cc: Arnaldo Carvalho de Melo >> Cc: Namhyung Kim > So, I'm having this problem when this patch is applied. [SNIP] > > nothing added to commit but untracked files present (use "git add" to track) > [acme@jouet linux]$ rm -f tools/perf/BUILD_TEST_FEATURE_DUMP tools/perf/make_no_libbpf tools/perf/make_no_newt > [acme@jouet linux]$ perf stat make -C tools/perf build-test > make: Entering directory '/home/acme/git/linux/tools/perf' > Testing Makefile > - /home/acme/git/linux/tools/perf/BUILD_TEST_FEATURE_DUMP: cd . && make FEATURE_DUMP_COPY=/home/acme/git/linux/tools/perf/BUILD_TEST_FEATURE_DUMP feature-dump > cd . && make FEATURE_DUMP_COPY=/home/acme/git/linux/tools/perf/BUILD_TEST_FEATURE_DUMP feature-dump > - make_doc: cd . && make -f Makefile DESTDIR=/tmp/tmp.lLyAWJ2KUJ doc FEATURES_DUMP=/home/acme/git/linux/tools/perf/BUILD_TEST_FEATURE_DUMP > - make_no_libperl: cd . && make -f Makefile DESTDIR=/tmp/tmp.iPREXpyGhh NO_LIBPERL=1 FEATURES_DUMP=/home/acme/git/linux/tools/perf/BUILD_TEST_FEATURE_DUMP > cd . && make -f Makefile DESTDIR=/tmp/tmp.iPREXpyGhh NO_LIBPERL=1 FEATURES_DUMP=/home/acme/git/linux/tools/perf/BUILD_TEST_FEATURE_DUMP > BUILD: Doing 'make -j4' parallel build > GEN common-cmds.h > CC fixdep.o > CC perf-read-vdso32 > In file included from /usr/include/features.h:389:0, > from /usr/include/stdio.h:27, > from perf-read-vdso.c:1: > /usr/include/gnu/stubs.h:7:27: fatal error: gnu/stubs-32.h: No such file or directory > compilation terminated. > Makefile.perf:416: recipe for target 'perf-read-vdso32' failed > make[4]: *** [perf-read-vdso32] Error 1 > make[4]: *** Waiting for unfinished jobs.... > LD fixdep-in.o > LINK fixdep > PERF_VERSION = 4.4.g80fcfd7 > Makefile:68: recipe for target 'all' failed > make[3]: *** [all] Error 2 > test: test -x ./perf > tests/make:274: recipe for target 'make_no_libperl' failed > make[2]: *** [make_no_libperl] Error 1 > tests/make:7: recipe for target 'all' failed > make[1]: *** [all] Error 2 > Makefile:81: recipe for target 'build-test' failed > make: *** [build-test] Error 2 > make: Leaving directory '/home/acme/git/linux/tools/perf' > This is the problem of test-compile-32. In ./tools/build/feature/test-compile.c, we check the '-m32' compiler flag but don't check include files. Could you please have a look at your environment? Do you have glibc-devel-i386 installed? What's the result of $ gcc -m32 tools/build/feature/test-compile.c I guess in your platform you can compile and link test-compile.c without gnu/stubs-32.h. Then we need to improve test-compile.c to make it check headers also. Another question is why you don't meet this error before this patch. It seems test-compile-32 should also pass... Thank you.