From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOI5q-0004iK-5l for qemu-devel@nongnu.org; Tue, 26 Jan 2016 23:52:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOI5m-0004iq-VF for qemu-devel@nongnu.org; Tue, 26 Jan 2016 23:52:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOI5m-0004ik-P5 for qemu-devel@nongnu.org; Tue, 26 Jan 2016 23:52:30 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 19199C0A9CC3 for ; Wed, 27 Jan 2016 04:52:30 +0000 (UTC) References: <1453760690-21221-1-git-send-email-wexu@redhat.com> <20160126064415.GJ23224@ad.usersys.redhat.com> From: Jason Wang Message-ID: <56A84D02.5050707@redhat.com> Date: Wed, 27 Jan 2016 12:52:18 +0800 MIME-Version: 1.0 In-Reply-To: <20160126064415.GJ23224@ad.usersys.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 0/10] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , wexu@redhat.com Cc: victork@redhat.com, mst@redhat.com, yvugenfi@redhat.com, qemu-devel@nongnu.org, marcel@redhat.com, dfleytma@redhat.com On 01/26/2016 02:44 PM, Fam Zheng wrote: > On Tue, 01/26 06:24, wexu@redhat.com wrote: >> Wei Xu (10): >> 'Segment', 'Chain' and 'Status' enumeration. >> Initilize & Cleanup. >> Chain lookup and packets caching. >> Tcp general data coalescing >> The draining timer >> IPv4 checksum. >> TCP control packet handling >> Sanity check & More bypass cases check. >> IPv6 support. >> Statistics. > Please add subsystem prefixes to subjects, like: > > "virtio-net: IPv6 support" > "virtio-net: Statistics And need to be more verbose. E.g: - "Statistics" is too generic, something like "TCP coalescing statistics" is much better. - "virtio-net: IPv6 support" which is really confusing since it lacks some context. Reviewers may suspect there's no ipv6 support in the past. - "Tcp general data coalescing, the parameters is a little bit horrible, it's complicated to read, should can be optimized later." is too long to be a subject. "Tcp general data coalescing" should be ok. For personal comment like "the parameters is a little bit horrible, it's complicated to read, should can be optimized later." could be places below '---' in the patch. And need a more verbose commit log please. At least I could not figure out what is happening just form most of the commit logs. [1] is a very good documentation for how to describe your changes, please have a look at that and describe the changes correctly in each commit log. You can also have a look at git history to see how it was done. [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n106 Thanks > > This applies to the cover letter too. > > (nit-pick: period "." is not necessary) > > Fam >