From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v4 4/6] drm/dsi: Check for used channels Date: Wed, 27 Jan 2016 10:46:05 +0530 Message-ID: <56A85295.6040705@codeaurora.org> References: <1448884892-7731-1-git-send-email-architt@codeaurora.org> <1449751300-2841-1-git-send-email-architt@codeaurora.org> <1449751300-2841-5-git-send-email-architt@codeaurora.org> <20160121161059.GD647@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160121161059.GD647@ulmo.nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, a.hajda@samsung.com, dri-devel@lists.freedesktop.org List-Id: linux-arm-msm@vger.kernel.org CgpPbiAwMS8yMS8yMDE2IDA5OjQxIFBNLCBUaGllcnJ5IFJlZGluZyB3cm90ZToKPiBPbiBUaHUs IERlYyAxMCwgMjAxNSBhdCAwNjoxMTozOFBNICswNTMwLCBBcmNoaXQgVGFuZWphIHdyb3RlOgo+ PiBXZSBkb24ndCBjaGVjayB3aGV0aGVyIGEgcHJldmlvdXNseSByZWdpc3RlcmVkIG1pcGlfZHNp X2RldmljZSB1bmRlciB0aGUKPj4gc2FtZSBob3N0IHNoYXJlcyB0aGUgc2FtZSB2aXJ0dWFsIGNo YW5uZWwuCj4+Cj4+IEJlZm9yZSByZWdpc3RlcmluZywgY2hlY2sgaWYgYW55IG9mIHRoZSByZWdp c3RlcmVkIGRldmljZXMgZG9lc24ndAo+PiBhbHJlYWR5IGhhdmUgdGhlIHNhbWUgdmlydHVhbCBj aGFubmVsLgo+Pgo+PiBUaGlzIHdhc24ndCBjcnVjaWFsIHdoZW4gYWxsIHRoZSBkZXZpY2VzIHVu ZGVyIGEgaG9zdCB3ZXJlIHBvcHVsYXRlZCB2aWEKPj4gRFQuIE5vdyB0aGF0IHdlIGFsc28gc3Vw cG9ydCBjcmVhdGluZyBkZXZpY2VzIG1hbnVhbGx5LCB3ZSBjb3VsZCBlbmQgdXAKPj4gaW4gYSBz aXR1YXRpb24gd2hlcmUgYSBkcml2ZXIgdHJpZXMgdG8gY3JlYXRlIGEgZGV2aWNlIHdpdGggYSB2 aXJ0dWFsCj4+IGNoYW5uZWwgYWxyZWFkeSB0YWtlbiBieSBhIGRldmljZSBwb3B1bGF0ZWQgaW4g RFQuCj4+Cj4+IFJldmlld2VkLWJ5OiBBbmRyemVqIEhhamRhIDxhLmhhamRhQHNhbXN1bmcuY29t Pgo+PiBTaWduZWQtb2ZmLWJ5OiBBcmNoaXQgVGFuZWphIDxhcmNoaXR0QGNvZGVhdXJvcmEub3Jn Pgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vZHJtX21pcGlfZHNpLmMgfCAyNiArKysrKysr KysrKysrKysrKysrKysrKystLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQo+Cj4gSSBkb24ndCB0aGluayB0aGlzIGlzIG5lY2Vzc2FyeS4gVGhl IGRldmljZSBuYW1lIHdpbGwgYmUgY29tcG9zZWQgb2YgdGhlCj4gaG9zdCdzIG5hbWUsIGEgJy4n IGFuZCB0aGUgdmlydHVhbCBjaGFubmVsIElELCBhbmQgdGhlIGRldmljZSBjb3JlIHdpbGwKPiBy ZWZ1c2UgdG8gY3JlYXRlIHR3byBkZXZpY2VzIHdpdGggdGhlIHNhbWUgbmFtZS4KClRoYXQncyBh IGdvb2QgcG9pbnQuIEknbGwgZHJvcCB0aGlzIHBhdGNoLgoKQXJjaGl0Cgo+Cj4gVGhpZXJyeQo+ CgotLSAKVGhlIFF1YWxjb21tIElubm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9m IHRoZSBDb2RlIEF1cm9yYSAKRm9ydW0sIGhvc3RlZCBieSBUaGUgTGludXggRm91bmRhdGlvbgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753666AbcA0FQS (ORCPT ); Wed, 27 Jan 2016 00:16:18 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37754 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753571AbcA0FQN (ORCPT ); Wed, 27 Jan 2016 00:16:13 -0500 Subject: Re: [PATCH v4 4/6] drm/dsi: Check for used channels To: Thierry Reding References: <1448884892-7731-1-git-send-email-architt@codeaurora.org> <1449751300-2841-1-git-send-email-architt@codeaurora.org> <1449751300-2841-5-git-send-email-architt@codeaurora.org> <20160121161059.GD647@ulmo.nvidia.com> Cc: dri-devel@lists.freedesktop.org, a.hajda@samsung.com, jani.nikula@linux.intel.com, linux-kernel@vger.kernel.org, airlied@linux.ie, daniel@ffwll.ch, l.stach@pengutronix.de, robh@kernel.org, linux-arm-msm@vger.kernel.org From: Archit Taneja Message-ID: <56A85295.6040705@codeaurora.org> Date: Wed, 27 Jan 2016 10:46:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20160121161059.GD647@ulmo.nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/2016 09:41 PM, Thierry Reding wrote: > On Thu, Dec 10, 2015 at 06:11:38PM +0530, Archit Taneja wrote: >> We don't check whether a previously registered mipi_dsi_device under the >> same host shares the same virtual channel. >> >> Before registering, check if any of the registered devices doesn't >> already have the same virtual channel. >> >> This wasn't crucial when all the devices under a host were populated via >> DT. Now that we also support creating devices manually, we could end up >> in a situation where a driver tries to create a device with a virtual >> channel already taken by a device populated in DT. >> >> Reviewed-by: Andrzej Hajda >> Signed-off-by: Archit Taneja >> --- >> drivers/gpu/drm/drm_mipi_dsi.c | 26 ++++++++++++++++++++++++-- >> 1 file changed, 24 insertions(+), 2 deletions(-) > > I don't think this is necessary. The device name will be composed of the > host's name, a '.' and the virtual channel ID, and the device core will > refuse to create two devices with the same name. That's a good point. I'll drop this patch. Archit > > Thierry > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation