From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57221)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1aOIm1-0005nU-Cy
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 00:36:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1aOIly-0005XZ-3a
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 00:36:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52379)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1aOIlx-0005XI-Ul
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 00:36:06 -0500
References: <1453790613-8308-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<56A7A5FA.9020406@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56A8573A.4090005@redhat.com>
Date: Wed, 27 Jan 2016 13:35:54 +0800
MIME-Version: 1.0
In-Reply-To: <56A7A5FA.9020406@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] net/filter: Fix the output information
 for command 'info network'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, Yang Hongyang <hongyang.yang@easystack.cn>



On 01/27/2016 12:59 AM, Eric Blake wrote:
> On 01/25/2016 11:43 PM, zhanghailiang wrote:
>> The properties of netfilter object could be changed by 'qom-set'
>> command, but the output of 'info network' command is not updated,
>> because it got the old information through nf->info_str, it will
>> not be updated while we change the value of netfilter's property.
>>
>> Here we split a helper function that could collect the output
>> information for filter, and also remove the useless member
>> 'info_str' from struct NetFilterState.
>>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Cc: Jason Wang <jasowang@redhat.com>
>> Cc: Eric Blake <eblake@redhat.com>
>> Cc: Markus Armbruster <armbru@redhat.com>
>> Cc: Yang Hongyang <hongyang.yang@easystack.cn>
>> ---
>> v2:
>> - write the information to monitor directly instead of
>>   printing into a temporary string before output them. (Eric's comment)
> Looks a lot nicer compared to v1!
> Reviewed-by: Eric Blake <eblake@redhat.com>
>

Applied to -net.

Thanks