From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH] mm: fix pfn_t to page conversion in vm_insert_mixed Date: Wed, 27 Jan 2016 09:06:37 +0200 Message-ID: <56A86C7D.6080708@ti.com> References: <20160126183751.9072.22772.stgit@dwillia2-desk3.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0988549784==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id 74B7B6E687 for ; Tue, 26 Jan 2016 23:06:55 -0800 (PST) In-Reply-To: <20160126183751.9072.22772.stgit@dwillia2-desk3.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Williams , dri-devel@lists.freedesktop.org Cc: Dave Hansen , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, akpm@linux-foundation.org List-Id: dri-devel@lists.freedesktop.org --===============0988549784== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN" --BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26/01/16 20:37, Dan Williams wrote: > pfn_t_to_page() honors the flags in the pfn_t value to determine if a > pfn is backed by a page. However, vm_insert_mixed() was originally > written to use pfn_valid() to make this determination. To restore the > old/correct behavior, ignore the pfn_t flags in the !pfn_t_devmap() cas= e > and fallback to trusting pfn_valid(). >=20 > Fixes: 01c8f1c44b83 ("mm, dax, gpu: convert vm_insert_mixed to pfn_t") Thanks, this fixes the crash with omapdrm. Tested-by: Tomi Valkeinen Tomi --BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWqGx9AAoJEPo9qoy8lh71hkQP/jMqrvyEt5BTGxhouxeSpUE+ kIL+fJFVRpfeE+QO3bXRFyuXt6NoT9F+IGzPDBtEJHnc/7vdyDVpLoI+bP9PpqJM R6faTLy2aE+7XG/2JrtUtk1XepsHyl4yOMEd3vpKh60PIAc+YhEC0PCDOgoyJnHW XOlhNoloY/bIBP1NHwbK3ZgR70KIhCBQlAxRqlNp1c2LgHr7weriCzMhD8COOYsk 93VjZ/Az4VSkRGbmGyL+lFk9VEzhPpypE4JzPHG1+lYT8T0eyd8s1RLwaOjJ66gW 6WSvVgcb/jgu2m30gClcx8ZSOwSXDgG7aDyo6oMwUucoF3zNwJvG9q99Q0PI4Z8M gfBighuQaGZWATNWRuJyA6ef6VkXto4IuYPnzlSs1DA+7gSS3tSg2plp1/Xuykt2 1RvKkiI2sFqs2X8Z3uVDwNLofvGrvdiSrMiRraWwaiyvA0nlaryR7qx8FOYbOZhK wJB4CPu0hGCd+tah2/wfvwGCcN9vCNXrxH4vzBOkmd2wxfBVfJWopDvh1sqg+DsW zn9ohbu/Cjr1h4EVwxlsm3oFaFTG6JrxIy02bj2V4NycM20tfy1D0mi0bBlrzaYB w7Qs8PBZbEHodt8gy7m5VNWB/y0q2AnlTbLiYVrVIZ/YEc/vCPjMcX30D9Q+SGEB igPIEJDBcy+xWy04IuIg =vPcr -----END PGP SIGNATURE----- --BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN-- --===============0988549784== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0988549784==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f48.google.com (mail-qg0-f48.google.com [209.85.192.48]) by kanga.kvack.org (Postfix) with ESMTP id BA3606B0005 for ; Wed, 27 Jan 2016 02:06:54 -0500 (EST) Received: by mail-qg0-f48.google.com with SMTP id 6so158133984qgy.1 for ; Tue, 26 Jan 2016 23:06:54 -0800 (PST) Received: from comal.ext.ti.com (comal.ext.ti.com. [198.47.26.152]) by mx.google.com with ESMTPS id k30si5378747qgk.52.2016.01.26.23.06.53 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 26 Jan 2016 23:06:53 -0800 (PST) Subject: Re: [PATCH] mm: fix pfn_t to page conversion in vm_insert_mixed References: <20160126183751.9072.22772.stgit@dwillia2-desk3.amr.corp.intel.com> From: Tomi Valkeinen Message-ID: <56A86C7D.6080708@ti.com> Date: Wed, 27 Jan 2016 09:06:37 +0200 MIME-Version: 1.0 In-Reply-To: <20160126183751.9072.22772.stgit@dwillia2-desk3.amr.corp.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN" Sender: owner-linux-mm@kvack.org List-ID: To: Dan Williams , dri-devel@lists.freedesktop.org Cc: Dave Hansen , David Airlie , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, akpm@linux-foundation.org --BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26/01/16 20:37, Dan Williams wrote: > pfn_t_to_page() honors the flags in the pfn_t value to determine if a > pfn is backed by a page. However, vm_insert_mixed() was originally > written to use pfn_valid() to make this determination. To restore the > old/correct behavior, ignore the pfn_t flags in the !pfn_t_devmap() cas= e > and fallback to trusting pfn_valid(). >=20 > Fixes: 01c8f1c44b83 ("mm, dax, gpu: convert vm_insert_mixed to pfn_t") Thanks, this fixes the crash with omapdrm. Tested-by: Tomi Valkeinen Tomi --BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWqGx9AAoJEPo9qoy8lh71hkQP/jMqrvyEt5BTGxhouxeSpUE+ kIL+fJFVRpfeE+QO3bXRFyuXt6NoT9F+IGzPDBtEJHnc/7vdyDVpLoI+bP9PpqJM R6faTLy2aE+7XG/2JrtUtk1XepsHyl4yOMEd3vpKh60PIAc+YhEC0PCDOgoyJnHW XOlhNoloY/bIBP1NHwbK3ZgR70KIhCBQlAxRqlNp1c2LgHr7weriCzMhD8COOYsk 93VjZ/Az4VSkRGbmGyL+lFk9VEzhPpypE4JzPHG1+lYT8T0eyd8s1RLwaOjJ66gW 6WSvVgcb/jgu2m30gClcx8ZSOwSXDgG7aDyo6oMwUucoF3zNwJvG9q99Q0PI4Z8M gfBighuQaGZWATNWRuJyA6ef6VkXto4IuYPnzlSs1DA+7gSS3tSg2plp1/Xuykt2 1RvKkiI2sFqs2X8Z3uVDwNLofvGrvdiSrMiRraWwaiyvA0nlaryR7qx8FOYbOZhK wJB4CPu0hGCd+tah2/wfvwGCcN9vCNXrxH4vzBOkmd2wxfBVfJWopDvh1sqg+DsW zn9ohbu/Cjr1h4EVwxlsm3oFaFTG6JrxIy02bj2V4NycM20tfy1D0mi0bBlrzaYB w7Qs8PBZbEHodt8gy7m5VNWB/y0q2AnlTbLiYVrVIZ/YEc/vCPjMcX30D9Q+SGEB igPIEJDBcy+xWy04IuIg =vPcr -----END PGP SIGNATURE----- --BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753775AbcA0HHA (ORCPT ); Wed, 27 Jan 2016 02:07:00 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:60133 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbcA0HG6 (ORCPT ); Wed, 27 Jan 2016 02:06:58 -0500 Subject: Re: [PATCH] mm: fix pfn_t to page conversion in vm_insert_mixed To: Dan Williams , References: <20160126183751.9072.22772.stgit@dwillia2-desk3.amr.corp.intel.com> CC: Dave Hansen , David Airlie , , Julian Margetson , , From: Tomi Valkeinen Message-ID: <56A86C7D.6080708@ti.com> Date: Wed, 27 Jan 2016 09:06:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160126183751.9072.22772.stgit@dwillia2-desk3.amr.corp.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26/01/16 20:37, Dan Williams wrote: > pfn_t_to_page() honors the flags in the pfn_t value to determine if a > pfn is backed by a page. However, vm_insert_mixed() was originally > written to use pfn_valid() to make this determination. To restore the > old/correct behavior, ignore the pfn_t flags in the !pfn_t_devmap() cas= e > and fallback to trusting pfn_valid(). >=20 > Fixes: 01c8f1c44b83 ("mm, dax, gpu: convert vm_insert_mixed to pfn_t") Thanks, this fixes the crash with omapdrm. Tested-by: Tomi Valkeinen Tomi --BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWqGx9AAoJEPo9qoy8lh71hkQP/jMqrvyEt5BTGxhouxeSpUE+ kIL+fJFVRpfeE+QO3bXRFyuXt6NoT9F+IGzPDBtEJHnc/7vdyDVpLoI+bP9PpqJM R6faTLy2aE+7XG/2JrtUtk1XepsHyl4yOMEd3vpKh60PIAc+YhEC0PCDOgoyJnHW XOlhNoloY/bIBP1NHwbK3ZgR70KIhCBQlAxRqlNp1c2LgHr7weriCzMhD8COOYsk 93VjZ/Az4VSkRGbmGyL+lFk9VEzhPpypE4JzPHG1+lYT8T0eyd8s1RLwaOjJ66gW 6WSvVgcb/jgu2m30gClcx8ZSOwSXDgG7aDyo6oMwUucoF3zNwJvG9q99Q0PI4Z8M gfBighuQaGZWATNWRuJyA6ef6VkXto4IuYPnzlSs1DA+7gSS3tSg2plp1/Xuykt2 1RvKkiI2sFqs2X8Z3uVDwNLofvGrvdiSrMiRraWwaiyvA0nlaryR7qx8FOYbOZhK wJB4CPu0hGCd+tah2/wfvwGCcN9vCNXrxH4vzBOkmd2wxfBVfJWopDvh1sqg+DsW zn9ohbu/Cjr1h4EVwxlsm3oFaFTG6JrxIy02bj2V4NycM20tfy1D0mi0bBlrzaYB w7Qs8PBZbEHodt8gy7m5VNWB/y0q2AnlTbLiYVrVIZ/YEc/vCPjMcX30D9Q+SGEB igPIEJDBcy+xWy04IuIg =vPcr -----END PGP SIGNATURE----- --BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN--