From: "Li, Weigang" <weigang.li@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>, Joonsoo Kim <js1304@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Minchan Kim <minchan@kernel.org>,
"Dan Streetman" <ddstreet@ieee.org>,
<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support
Date: Wed, 27 Jan 2016 15:59:05 +0800 [thread overview]
Message-ID: <56A878C9.8050202@intel.com> (raw)
In-Reply-To: <20160127074140.GA30335@gondor.apana.org.au>
On 1/27/2016 3:41 PM, Herbert Xu wrote:
> On Tue, Jan 26, 2016 at 05:15:06PM +0900, Joonsoo Kim wrote:
>> From: Weigang Li <weigang.li@intel.com>
>>
>> Now, asynchronous compression APIs are supported. There is no asynchronous
>> compression driver now but this APIs can be used as front-end to
>> synchronous compression algorithm. In this case, scatterlist would be
>> linearlized when needed so it would cause some overhead.
>>
>> Signed-off-by: Weigang Li <weigang.li@intel.com>
>> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> I think we should be able to use this for the synchronous case
> too, like we do with skcipher and ahash.
>
> The main difference that I can see right now is that acomp always
> allocates a context through the request object while scomp does not.
>
> This difference is entirely artificial as we could also make the
> context conditional for acomp.
>
> The reason we had the shash/ahash division is because the shash
> interface offers a direct pointer interface while ahash is SG-based.
> Otherwise ahash is just as able as shash to handle synchronous
> requests.
>
> At this point in time I don't see such a fundamental distinction
> between acomp and scomp.
>
> Cheers,
>
The acomp is also SG-based, while scomp only accepts flat buffer.
next prev parent reply other threads:[~2016-01-27 7:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 8:15 [PATCH v2 00/10] Introduce new async/sync compression APIs Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 01/10] crypto/compress: remove unused pcomp interface Joonsoo Kim
2016-01-27 14:17 ` Herbert Xu
2016-01-26 8:15 ` [PATCH v2 02/10] crypto: add algorithm type specific flag, CRYPTO_ALG_PRIVATE Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 03/10] crypto/compress: introduce sychronuous compression API Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 04/10] crypto/compress: add asynchronous compression support Joonsoo Kim
2016-01-27 7:41 ` Herbert Xu
2016-01-27 7:59 ` Li, Weigang [this message]
2016-01-27 8:03 ` Herbert Xu
2016-01-27 8:09 ` Herbert Xu
2016-01-27 8:26 ` Li, Weigang
2016-01-28 3:19 ` Joonsoo Kim
2016-01-29 10:09 ` Herbert Xu
2016-02-01 2:11 ` Joonsoo Kim
2016-02-04 3:25 ` Li, Weigang
2016-02-04 3:28 ` Herbert Xu
2016-02-04 3:29 ` Herbert Xu
2016-02-04 3:50 ` Li, Weigang
2016-02-04 14:56 ` Herbert Xu
2016-02-04 7:17 ` Joonsoo Kim
2016-02-04 14:53 ` Herbert Xu
2016-02-04 16:19 ` Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 05/10] crypto/lzo: support new compression APIs Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 06/10] crypto/lz4: " Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 07/10] crypto/lz4hc: " Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 08/10] crypto/842: " Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 09/10] crypto/deflate: " Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 10/10] crypto/testmgr: add new compression APIs test Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A878C9.8050202@intel.com \
--to=weigang.li@intel.com \
--cc=davem@davemloft.net \
--cc=ddstreet@ieee.org \
--cc=herbert@gondor.apana.org.au \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.