Re: [Qemu-devel] [RFC 0/10] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest

[Wei Xu <wexu@redhat.com>]

On 01/27/2016 12:52 PM, Jason Wang wrote:
>
> On 01/26/2016 02:44 PM, Fam Zheng wrote:
>> On Tue, 01/26 06:24, wexu@redhat.com wrote:
>>> Wei Xu (10):
>>>    'Segment', 'Chain' and 'Status' enumeration.
>>>    Initilize & Cleanup.
>>>    Chain lookup and packets caching.
>>>    Tcp general data coalescing
>>>    The draining timer
>>>    IPv4 checksum.
>>>    TCP control packet handling
>>>    Sanity check & More bypass cases check.
>>>    IPv6 support.
>>>    Statistics.
>> Please add subsystem prefixes to subjects, like:
>>
>>    "virtio-net: IPv6 support"
>>    "virtio-net: Statistics
> And need to be more verbose. E.g:
>
> - "Statistics" is too generic, something like "TCP coalescing
> statistics" is much better.
> - "virtio-net: IPv6 support" which is really confusing since it lacks
> some context. Reviewers may suspect there's no ipv6 support in the past.
> - "Tcp general data coalescing, the parameters is a little bit horrible,
> it's complicated to read, should can be optimized later." is too long to
> be a subject. "Tcp general data coalescing" should be ok. For personal
> comment like "the parameters is a little bit horrible, it's complicated
> to read, should can be optimized later." could be places below '---' in
> the patch.
>
> And need a more verbose commit log please. At least I could not figure
> out what is happening just form most of the commit logs. [1] is a very
> good documentation for how to describe your changes, please have a look
> at that and describe the changes correctly in each commit log. You can
> also have a look at git history to see how it was done.
>
> [1]
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n106
OK, Thanks a lot.

Wei
>
> Thanks
>> This applies to the cover letter too.
>>
>> (nit-pick: period "." is not necessary)
>>
>> Fam
>>
>