From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gi-Oh Kim Date: Wed, 27 Jan 2016 10:36:33 +0000 Subject: Re: [lm-sensors] [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit Message-Id: <56A89DB1.2000200@profitbricks.com> List-Id: References: <1453722067-6747-1-git-send-email-gi-oh.kim@profitbricks.com> <20160126022531.GA23394@hr-amur2> <56A7511F.1050205@profitbricks.com> <20160127064537.GA25036@hr-amur2> In-Reply-To: <20160127064537.GA25036@hr-amur2> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Huang Rui Cc: Guenter Roeck , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" , Borislav Petkov On 27.01.2016 07:45, Huang Rui wrote: > On Tue, Jan 26, 2016 at 11:57:35AM +0100, Gi-Oh Kim wrote: >> >> On 26.01.2016 03:25, Huang Rui wrote: >>> On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote: >> Thanks for your reply. >> I'm not completely sure that the reserved bits are always zero. >> Are they always zero? >> Or do we need bit-masking like following? >> > Reserved bits aren't always zero. But here they are reserved for > ApmTdpLimit expansion. > > Yes, we would better add bit-masking here. :-) > >> -------------- 8< ----------------- >> Subject: [PATCH] hwmon: (fam15h_power) Add bit masking for tdp_limit >> >> Add bit masking to read ApmTdpLimit precisely >> >> Signed-off-by: Gioh Kim >> --- >> drivers/hwmon/fam15h_power.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c >> index f77eb97..edbcf6c 100644 >> --- a/drivers/hwmon/fam15h_power.c >> +++ b/drivers/hwmon/fam15h_power.c >> @@ -90,7 +90,11 @@ static ssize_t show_power(struct device *dev, >> pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5), >> REG_TDP_LIMIT3, &val); >> >> - tdp_limit = val >> 16; >> + if (boot_cpu_data.x86_model >= 0x60) >> + tdp_limit = val >> 16; > You need add CPU family check and a comment to mention bit field > change. This updates since family 15h and model 60h. > > if (boot_cpu_data.x86 = 0x15 && boot_cpu_data.x86_model >= 0x60) I'm going to send a formal patch. Thank you. > > Thanks, > Rui -- Best regards, Gi-Oh Kim _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754312AbcA0Kgj (ORCPT ); Wed, 27 Jan 2016 05:36:39 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:37647 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948AbcA0Kgg (ORCPT ); Wed, 27 Jan 2016 05:36:36 -0500 Subject: Re: [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit To: Huang Rui References: <1453722067-6747-1-git-send-email-gi-oh.kim@profitbricks.com> <20160126022531.GA23394@hr-amur2> <56A7511F.1050205@profitbricks.com> <20160127064537.GA25036@hr-amur2> Cc: Guenter Roeck , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" , Borislav Petkov From: Gi-Oh Kim Message-ID: <56A89DB1.2000200@profitbricks.com> Date: Wed, 27 Jan 2016 11:36:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160127064537.GA25036@hr-amur2> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.01.2016 07:45, Huang Rui wrote: > On Tue, Jan 26, 2016 at 11:57:35AM +0100, Gi-Oh Kim wrote: >> >> On 26.01.2016 03:25, Huang Rui wrote: >>> On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote: >> Thanks for your reply. >> I'm not completely sure that the reserved bits are always zero. >> Are they always zero? >> Or do we need bit-masking like following? >> > Reserved bits aren't always zero. But here they are reserved for > ApmTdpLimit expansion. > > Yes, we would better add bit-masking here. :-) > >> -------------- 8< ----------------- >> Subject: [PATCH] hwmon: (fam15h_power) Add bit masking for tdp_limit >> >> Add bit masking to read ApmTdpLimit precisely >> >> Signed-off-by: Gioh Kim >> --- >> drivers/hwmon/fam15h_power.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c >> index f77eb97..edbcf6c 100644 >> --- a/drivers/hwmon/fam15h_power.c >> +++ b/drivers/hwmon/fam15h_power.c >> @@ -90,7 +90,11 @@ static ssize_t show_power(struct device *dev, >> pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5), >> REG_TDP_LIMIT3, &val); >> >> - tdp_limit = val >> 16; >> + if (boot_cpu_data.x86_model >= 0x60) >> + tdp_limit = val >> 16; > You need add CPU family check and a comment to mention bit field > change. This updates since family 15h and model 60h. > > if (boot_cpu_data.x86 == 0x15 && boot_cpu_data.x86_model >= 0x60) I'm going to send a formal patch. Thank you. > > Thanks, > Rui -- Best regards, Gi-Oh Kim