From: Arun Siluvery <arun.siluvery@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Capture revision id in error state
Date: Wed, 27 Jan 2016 11:44:07 +0000 [thread overview]
Message-ID: <56A8AD87.7030406@linux.intel.com> (raw)
In-Reply-To: <20160127113357.GY23290@intel.com>
On 27/01/2016 11:33, Ville Syrjälä wrote:
> On Tue, Jan 26, 2016 at 05:52:51PM +0000, Arun Siluvery wrote:
>> Revision id along with device id is useful in better identification of the HW
>> and its limitations so include this detail in error state.
>>
>> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>> index 7eeb244..f3ddc3b 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>> @@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
>> err_printf(m, "Reset count: %u\n", error->reset_count);
>> err_printf(m, "Suspend count: %u\n", error->suspend_count);
>> err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
>> + err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision);
>
> "PCI revision" maybe?
sure, makes it more clear.
regards
Arun
>
>> err_printf(m, "IOMMU enabled?: %d\n", error->iommu);
>>
>> if (HAS_CSR(dev)) {
>> --
>> 1.9.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-27 11:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 17:52 [PATCH] drm/i915: Capture revision id in error state Arun Siluvery
2016-01-27 11:33 ` Ville Syrjälä
2016-01-27 11:44 ` Arun Siluvery [this message]
2016-01-27 17:46 ` Chris Wilson
2016-01-27 17:38 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-01-28 14:33 ` Patchwork
2016-01-28 17:18 ` [PATCH] drm/i915: Capture PCI revision and subsytem details " Arun Siluvery
2016-02-10 7:47 ` Daniel Vetter
2016-01-29 10:27 ` ✗ Fi.CI.BAT: warning for drm/i915: Capture revision id in error state (rev2) Patchwork
2016-01-29 11:08 ` Arun Siluvery
2016-02-10 7:48 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A8AD87.7030406@linux.intel.com \
--to=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.