From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH V1 1/1] jobstats: added function abort for job Date: Wed, 27 Jan 2016 15:37:48 +0200 Message-ID: <56A8C82C.3080107@redhat.com> References: <1453824934-10650-1-git-send-email-marcinx.kerlin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Marcin Kerlin , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 344E995AB for ; Wed, 27 Jan 2016 14:37:50 +0100 (CET) In-Reply-To: <1453824934-10650-1-git-send-email-marcinx.kerlin@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/26/2016 06:15 PM, Marcin Kerlin wrote: > This patch adds new function rte_jobstats_abort. It marks *job* as finished > and time of this work will be add to management time instead of execution time. > This function should be used instead of rte_jobstats_finish if condition occure, > condition is defined by the application for example when receiving n>0 packets. > > Signed-off-by: Marcin Kerlin > --- > lib/librte_jobstats/rte_jobstats.c | 22 ++++++++++++++++++++++ > lib/librte_jobstats/rte_jobstats.h | 17 +++++++++++++++++ > lib/librte_jobstats/rte_jobstats_version.map | 7 +++++++ > 3 files changed, 46 insertions(+) > [...] > diff --git a/lib/librte_jobstats/rte_jobstats.h b/lib/librte_jobstats/rte_jobstats.h > index de6a89a..9995319 100644 > --- a/lib/librte_jobstats/rte_jobstats.h > +++ b/lib/librte_jobstats/rte_jobstats.h > @@ -90,6 +90,9 @@ struct rte_jobstats { > uint64_t exec_cnt; > /**< Execute count. */ > > + uint64_t last_job_time; > + /**< Last job time */ > + > char name[RTE_JOBSTATS_NAMESIZE]; > /**< Name of this job */ > AFAICS this is an ABI break and as such, needs to be preannounced, see http://dpdk.org/doc/guides/contributing/versioning.html For 2.3 it'd need to be a CONFIG_RTE_NEXT_ABI feature. - Panu -