From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] arm: clean up build variables Date: Wed, 27 Jan 2016 08:30:17 -0600 Message-ID: <56A8D479.2060303@cardoe.com> References: <1453326479-19885-1-git-send-email-cardoe@cardoe.com> <1453721226.4320.127.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9015419814831943661==" Return-path: In-Reply-To: <1453721226.4320.127.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: Stefano Stabellini , Jan Beulich List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============9015419814831943661== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1BIkkuWAXiA4iL9HLUFDdIteXajwkJAX1" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1BIkkuWAXiA4iL9HLUFDdIteXajwkJAX1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1/25/16 5:27 AM, Ian Campbell wrote: > On Wed, 2016-01-20 at 15:47 -0600, Doug Goldstein wrote: >> This consolidates some of the different variables used for the ARM >> builds. This change was prompted by the Kconfig changes but looking ba= ck >> in time the CONFIG_ARM_{32,64} variables existed before Kconfig so thi= s >> should just be a generic cleanup. >> >> Signed-off-by: Doug Goldstein >> --- >> xen/arch/arm/Makefile | 8 ++++---- >> xen/arch/arm/Rules.mk | 18 ++++-------------- >> xen/drivers/passthrough/Makefile | 2 +- >> 3 files changed, 9 insertions(+), 19 deletions(-) >> >> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile >> index 2f050f5..0d11c0f 100644 >> --- a/xen/arch/arm/Makefile >> +++ b/xen/arch/arm/Makefile >> @@ -1,7 +1,7 @@ >> -subdir-$(arm32) +=3D arm32 >> -subdir-$(arm64) +=3D arm64 >> +subdir-$(CONFIG_ARM_32) +=3D arm32 >> +subdir-$(CONFIG_ARM_64) +=3D arm64 >> subdir-y +=3D platforms >> -subdir-$(arm64) +=3D efi >> +subdir-$(CONFIG_ARM_64) +=3D efi >> =20 >> obj-$(EARLY_PRINTK) +=3D early_printk.o >> obj-y +=3D cpu.o >> @@ -52,7 +52,7 @@ ALL_OBJS :=3D $(TARGET_SUBARCH)/head.o $(ALL_OBJS) >> =20 >> $(TARGET): $(TARGET)-syms $(TARGET).axf >> $(OBJCOPY) -O binary -S $< $@ >> -ifeq (arm64,$(XEN_TARGET_ARCH)) >> +ifdef CONFIG_ARM_64 >=20 > The old way looks to be the prevailing normal form. I don't especially > object to the change but things ought to remain consistent. Which part? Using arm32/arm64? Or having the if blocks rather than var-$(CONFIG_THING) ? My goal here is consistency and that was to standardize on the form of var-$(CONFIG_THING) across the board. >=20 > For the rest: > Acked-by: Ian Campbell < ian.campbell@citrix.com > >=20 > FYI I'm not committing things right now due to network issues between t= he > machine(s) I use for such things. >=20 > Ian. >=20 --=20 Doug Goldstein --1BIkkuWAXiA4iL9HLUFDdIteXajwkJAX1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWqNR8XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUxkMP/REaRI/9s0NcTqt6NE3EEWl6 tofxKyFXBVNNqPr4FLRBz+pEHMRe5JL8Ui8I6TtAQd1Oi6ucvQgYgw3reWIRakEN +qtDPU/iMTBrlHdaNqBG/q2QI2N3Qwohyix34Us8vgcdamQM/5AZybTh3odNzD9D Ft/BkJj9UC5aKD0bdpK3z1ClQGeEad8dFbPZTyvpHAPPeqGSFo3ixqU5jydVtxwM OSc286W9zt6JXxtIoV4/JZgeTCoK5X+CyAef5Bv2Sz76pqhqj3ojvC82kYf7p4yj 1CFNbTQSoqUM/K8l4BCw5ZQCs1ujfcbUtsxZqYKhBkgQpCLSO/aktqlLggh73Wjx +3Hxaxej6pTzNxLVI0fWk+GeM2d6iOYtM/gU5nz61yFXX41JROW/g9uTvLlFQTGU YFnIo5+4prCvOeVmvn/xPmmNjCN0BjBCP+1mVstQKnQGro/fnzgrq8sOKlkftvmi RGzZfqZHxc6Ozf5+AU6O/uD85oJYevGccryu69soJHOPn9ARZEPbt8y2vGAoSnIa 5LDRFL+IidZOIak0Btyv+JLSamNA3NWEhU7+AStLGYdm+6VGEwwrHoIYmLGyzFQ1 kEtEvpZ1F4yn25PCKmehjO+xaEl1T/O4w3thYXyUHRYRXExDDU5P9KvKt9CaK5m0 qjT9PcypL5T4jK9S8HWF =pCVi -----END PGP SIGNATURE----- --1BIkkuWAXiA4iL9HLUFDdIteXajwkJAX1-- --===============9015419814831943661== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============9015419814831943661==--