From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCHv3] 1/3] libxc: prefer using privcmd character device Date: Wed, 27 Jan 2016 08:40:56 -0600 Message-ID: <56A8D6F8.5080806@cardoe.com> References: <1448998075-23878-1-git-send-email-cardoe@cardoe.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7647426154196107654==" Return-path: In-Reply-To: <1448998075-23878-1-git-send-email-cardoe@cardoe.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen@bugs.xenproject.org Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============7647426154196107654== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IvLh22Toa5jDbPXNpNlaK0KNd1TJLUJdn" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IvLh22Toa5jDbPXNpNlaK0KNd1TJLUJdn Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable graft 34 ^ close it thanks On 12/1/15 1:27 PM, Doug Goldstein wrote: > Prefer using the character device over the proc file if the character > device exists. This follows similar conversions of xenbus to avoid > issues with FMODE_ATOMIC_POS added in Linux 3.14 and newer. >=20 > CC: Ian Jackson > CC: Stefano Stabellini > CC: Ian Campbell > CC: Wei Liu > Signed-off-by: Doug Goldstein > --- > tools/libxc/xc_linux_osdep.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/tools/libxc/xc_linux_osdep.c b/tools/libxc/xc_linux_osdep.= c > index 76c55ff..c3a3a14 100644 > --- a/tools/libxc/xc_linux_osdep.c > +++ b/tools/libxc/xc_linux_osdep.c > @@ -46,7 +46,13 @@ > static xc_osdep_handle linux_privcmd_open(xc_interface *xch) > { > int flags, saved_errno; > - int fd =3D open("/proc/xen/privcmd", O_RDWR); > + int fd =3D open("/dev/xen/privcmd", O_RDWR); /* prefer this newer = interface */ > + > + if ( fd =3D=3D -1 && ( errno =3D=3D ENOENT || errno =3D=3D ENXIO |= | errno =3D=3D ENODEV )) > + { > + /* Fallback to /proc/xen/privcmd */ > + fd =3D open("/proc/xen/privcmd", O_RDWR); > + } > =20 > if ( fd =3D=3D -1 ) > { >=20 --=20 Doug Goldstein --IvLh22Toa5jDbPXNpNlaK0KNd1TJLUJdn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWqNb6XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUXFkP/iLu9a/gJ/nDUgFzV+dz6aY+ +kM6hm/2PgJFYHsaU61P4tqVq3AmDnDEAIf9qb/UKqH586Ij1n15hYZXTCEBnYMs tUMJpui0Ryna4Aeilo6q9IOeViO+fWD8c9fkbFwGlnWw4wNBraj6KXmdAohiVfvX bxjfq4vgAgHjnoru2FEc/F2NG3uRWl5vQHNPJwLWRCSvmZsQxIARS+Y7ptgxXMKB o3cMp1LoRtj8JJL6ltkRyqoH5EVbiB63Tk88Sf3sd9dtFz5WY7bYUlgGW9duSOTQ yJLPDStHzWFgpntgfUACAVXelxavlumvTEWQDTMqKlcWbMHjKfzr70yIzHfhWCTf xh8sJGHwPcc2j7KZkgYsl9h0b8KfCdFk+ecrMqZN+dJGVaommzNI6AvOOmosXGrz KhhHvb4ANI5OvEOuDK6FQoTxfl75m/aa5bUDaz85dw26YdIlcANOCXFAGoXB7X5a FtDZzFLtJhEwxKK8/kEp6hSNa8UwI9Cjdi32wJ9G8bEc6a8WAHj5XGzDwu3hLvWd i3P9AUeM+X3AISUKPGwReeopZjIhnuQlYfXnMQ5pjNostaiNuHgm5+2OKRnjrzJA JAcRgXho/YPsYAR1b+XPbNmMlyOFXiV48DpukoNU3koqE2cdXMkLd7DLFZVnBtOr f65MGlgz0CSIBuqmbnoG =4bg3 -----END PGP SIGNATURE----- --IvLh22Toa5jDbPXNpNlaK0KNd1TJLUJdn-- --===============7647426154196107654== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7647426154196107654==--