From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] arm: clean up build variables Date: Wed, 27 Jan 2016 09:11:55 -0600 Message-ID: <56A8DE3B.7020409@cardoe.com> References: <1453326479-19885-1-git-send-email-cardoe@cardoe.com> <1453721226.4320.127.camel@citrix.com> <56A8D479.2060303@cardoe.com> <56A8E5EF02000078000CB9E5@prv-mh.provo.novell.com> <1453907131.26591.29.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2421464234891454431==" Return-path: In-Reply-To: <1453907131.26591.29.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Jan Beulich Cc: Stefano Stabellini , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2421464234891454431== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cxPaSfS7jTw8wvejFC1cMIl3r0DvQp8l5" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cxPaSfS7jTw8wvejFC1cMIl3r0DvQp8l5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1/27/16 9:05 AM, Ian Campbell wrote: > On Wed, 2016-01-27 at 07:44 -0700, Jan Beulich wrote: >>>>> On 27.01.16 at 15:30, wrote: >>> On 1/25/16 5:27 AM, Ian Campbell wrote: >>>> On Wed, 2016-01-20 at 15:47 -0600, Doug Goldstein wrote: >>>>> @@ -52,7 +52,7 @@ ALL_OBJS :=3D $(TARGET_SUBARCH)/head.o $(ALL_OBJS= ) >>>>> =20 >>>>> $(TARGET): $(TARGET)-syms $(TARGET).axf >>>>> $(OBJCOPY) -O binary -S $< $@ >>>>> -ifeq (arm64,$(XEN_TARGET_ARCH)) >>>>> +ifdef CONFIG_ARM_64 >>>> >>>> The old way looks to be the prevailing normal form. I don't >>>> especially >>>> object to the change but things ought to remain consistent. >>> >>> Which part? Using arm32/arm64? Or having the if blocks rather than >>> var-$(CONFIG_THING) ? >>> >>> My goal here is consistency and that was to standardize on the form o= f >>> var-$(CONFIG_THING) across the board. >> >> But there's no var-$(CONFIG_THING) in the code above. >=20 > Indeed, I was referring to the change from: >=20 > -ifeq (arm64,$(XEN_TARGET_ARCH)) >=20 > to >=20 > +ifdef CONFIG_ARM_64 >=20 > While: >=20 > ifeq ($(CONFIG_ARM_64),y) >=20 > is the more prevalent style. >=20 > Ian. >=20 Oh sure. We can do that. Would you like me to send a v2 or are you comfortable squashing that into the patch? --=20 Doug Goldstein --cxPaSfS7jTw8wvejFC1cMIl3r0DvQp8l5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWqN49XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUXegP/jHrgHtdiYnAO9kgVCk5U/3Z INbFZeIBCJrtX/B9ZFjFdhRUZVbNfGGgU/PNAPV+p36MydySr1rJorxkoA89lP44 UADhay+uyQ9wJioozGu20vVfBWwsP9WDfmvCQjGe3qpRfwgtXCABegst7+uEHVMa WQ1TdZW8YC77NuzOLJcxLDfWQovCL4Y/H4rQYeqPwMaJN3Nb6vjl3rILw1DmEoNj nPL89JYM8RU7T87V3vCBhW0IMzSGWs8Bb6voKcBsxvvy5rItMfmC1Axak73yPSjW xwmpZYLcVfvEdgY4C75eRIYni+NO9Z5Uhz0q5Wmq504LXDZdHvWuJDN6SnGxa596 nPZHZzzdo6hUfxVpmt4TNW5Lb3dV7DTA0duCXH3G3QDtrGOMcImoD4Rw91qduPu8 HkBn9Q7Q9NPV0tCU8peOIQfxImr9Ci9mIs3Dfck+xQDF3isEZbBC9BDG5oIblERO XUqYQz6c2WjtEfIgEHir0a1+Stl5KpfXnZZoSbU8kuekUAVipCCeQjyebnJ4DY15 vySvumlA5GaghGPE035JOiSeyO6LmpbOSdGDiRUgTcQq242T/viR5MfGkUBsJPiF Uuld+F1foMAcwdaopISbiaDemfRXtKXX8KQaa8iGRoUChGRvJpNHhvlH3nh0CNZu pZzFB3pQCuQA+Tk7gB2w =NyT5 -----END PGP SIGNATURE----- --cxPaSfS7jTw8wvejFC1cMIl3r0DvQp8l5-- --===============2421464234891454431== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2421464234891454431==--