From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] arm: clean up build variables Date: Wed, 27 Jan 2016 09:26:58 -0600 Message-ID: <56A8E1C2.6030108@cardoe.com> References: <1453326479-19885-1-git-send-email-cardoe@cardoe.com> <1453721226.4320.127.camel@citrix.com> <56A8D479.2060303@cardoe.com> <56A8E5EF02000078000CB9E5@prv-mh.provo.novell.com> <1453907131.26591.29.camel@citrix.com> <56A8DE3B.7020409@cardoe.com> <1453908284.26591.30.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4813864988552396172==" Return-path: In-Reply-To: <1453908284.26591.30.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Jan Beulich Cc: Stefano Stabellini , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============4813864988552396172== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iFDidGiOBsBhSBOBhBIhFOXs2E26Qxq7c" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iFDidGiOBsBhSBOBhBIhFOXs2E26Qxq7c Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1/27/16 9:24 AM, Ian Campbell wrote: > On Wed, 2016-01-27 at 09:11 -0600, Doug Goldstein wrote: >> On 1/27/16 9:05 AM, Ian Campbell wrote: >>> On Wed, 2016-01-27 at 07:44 -0700, Jan Beulich wrote: >>>>>>> On 27.01.16 at 15:30, wrote: >>>>> On 1/25/16 5:27 AM, Ian Campbell wrote: >>>>>> On Wed, 2016-01-20 at 15:47 -0600, Doug Goldstein wrote: >>>>>>> @@ -52,7 +52,7 @@ ALL_OBJS :=3D $(TARGET_SUBARCH)/head.o >>>>>>> $(ALL_OBJS) >>>>>>> =20 >>>>>>> $(TARGET): $(TARGET)-syms $(TARGET).axf >>>>>>> $(OBJCOPY) -O binary -S $< $@ >>>>>>> -ifeq (arm64,$(XEN_TARGET_ARCH)) >>>>>>> +ifdef CONFIG_ARM_64 >>>>>> >>>>>> The old way looks to be the prevailing normal form. I don't >>>>>> especially >>>>>> object to the change but things ought to remain consistent. >>>>> >>>>> Which part? Using arm32/arm64? Or having the if blocks rather than >>>>> var-$(CONFIG_THING) ? >>>>> >>>>> My goal here is consistency and that was to standardize on the form= >>>>> of >>>>> var-$(CONFIG_THING) across the board. >>>> >>>> But there's no var-$(CONFIG_THING) in the code above. >>> >>> Indeed, I was referring to the change from: >>> >>> -ifeq (arm64,$(XEN_TARGET_ARCH)) >>> >>> to >>> >>> +ifdef CONFIG_ARM_64 >>> >>> While: >>> >>> ifeq ($(CONFIG_ARM_64),y) >>> >>> is the more prevalent style. >>> >>> Ian. >>> >> >> Oh sure. We can do that. Would you like me to send a v2 or are you >> comfortable squashing that into the patch? >=20 > I may as well just do it, thanks. >=20 >=20 I'll change my style going forward to use that form as well. --=20 Doug Goldstein --iFDidGiOBsBhSBOBhBIhFOXs2E26Qxq7c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWqOHFXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUJ3oP/2raHIwBrX/Sgd2NErQXyYih cWJq3Yu2wNCDnubnPf29VnnvN19DtVSdsi5DujGvraeXVUHzoSxE+p833qDuOv0X 5kXwIusCpqrDxWluHiQHzYwyfWOGzBkQq4oGBgyM6UuyxZig/w5XrCOaPoXgrvEW EC3MPE7wuMs2wXjAX3vCfdVY3cHVyMiN2T9IdCHA+5zYxsiyw5DyEUmYuW7iZ3Eo BKOG6wH99iAXi0PVUiatAA9OM+ywX7okyaHw/lporicurXUeoxteJDFtUTW2ns1i SEsZjaIFwxF3xSE2mElZhKSwwFCFDKVsPbLe+R6f5cmzTHo3XjpsFRkgJNJhUpek NaJOsYrzYlj+CB8j5DtR8Vqt+8wsT/fTHGGjuIaKW2Ip4y6hDkF2YStJxEf0nZf0 cT2O9X2vLfUGoWeU8ivgp/sqkwgYvlUG5TqJaI2q70u/+gOzGadosP6yqFqTXtB7 b/ctF0+cLltmXj763MpQE2S8fYfNouKqIV/9eGr/BQDLxG9silnSCVbXcCB7BoBz na07QpX6fDSjgAFEKOgVnFutOUIj868+cqyrksXd+LB09xaxlOdtUNfEyX3A0wxR EE99cILLnPKjvwKdpxNXUCMVhuec8rSPq1ofj+3OzxBURJx2TMO2E8GB21/l40gu 0k59dsxUrdZnm1yUSXo8 =KXSb -----END PGP SIGNATURE----- --iFDidGiOBsBhSBOBhBIhFOXs2E26Qxq7c-- --===============4813864988552396172== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4813864988552396172==--