From: Eric Blake <eblake@redhat.com>
To: Hailiang Zhang <zhang.zhanghailiang@huawei.com>,
Zhang Chen <zhangchen.fnst@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>,
Jason Wang <jasowang@redhat.com>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>,
Gui jianfeng <guijianfeng@cn.fujitsu.com>,
"eddie.dong" <eddie.dong@intel.com>,
peter.huangpeng@huawei.com,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Yang Hongyang <hongyang.yang@easystack.cn>
Subject: Re: [Qemu-devel] [PATCH] net/traffic-mirrorer:Add traffic-mirroer
Date: Wed, 27 Jan 2016 09:10:49 -0700 [thread overview]
Message-ID: <56A8EC09.8070906@redhat.com> (raw)
In-Reply-To: <56A812E9.9030006@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
On 01/26/2016 05:44 PM, Hailiang Zhang wrote:
> On 2016/1/26 16:59, Zhang Chen wrote:
>> From: ZhangChen <zhangchen.fnst@cn.fujitsu.com>
>>
>> Traffic-mirrorer is a plugin of netfilter.
>> It make qemu has ability to copy and mirror guest's
>> net packet. we output packet to chardev.
>>
>> +static void traffic_mirrorer_setup(NetFilterState *nf, Error **errp)
>> +{
>> + MirrorerState *s = FILTER_TRAFFIC_MIRRORER(nf);
>> +
>> + if (!s->outdev) {
>> + error_setg(errp, "filter traffic mirrorer needs 'outdev'
>> property set!"
>> + "property set!");
>
> Duplicate 'property set!'.
For that matter, error_setg() messages should never end in '!'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-27 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 8:59 [Qemu-devel] [PATCH] net/traffic-mirrorer:Add traffic-mirroer Zhang Chen
2016-01-26 14:13 ` Yang Hongyang
2016-01-26 19:46 ` Dr. David Alan Gilbert
2016-01-27 1:42 ` Zhang Chen
2016-01-27 0:44 ` Hailiang Zhang
2016-01-27 1:32 ` Zhang Chen
2016-01-27 16:10 ` Eric Blake [this message]
2016-01-28 1:22 ` Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A8EC09.8070906@redhat.com \
--to=eblake@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=hongyang.yang@easystack.cn \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.