All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Meredith <andrew@anvil.org>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	Warren Sturm <warren.sturm@gmail.com>,
	Andy Walls <awalls@md.metrocast.net>
Subject: Re: [PATCH 1/2] Revert "[media] ivtv: avoid going past input/audio array"
Date: Wed, 27 Jan 2016 16:28:57 +0000	[thread overview]
Message-ID: <56A8F049.9000705@anvil.org> (raw)
In-Reply-To: <93fa669548266b15798131e0f5875bd85306caf4.1447242435.git.mchehab@osg.samsung.com>

Hi Mauro,

There was a flurry of activity around November last year, so thanks for 
that, but nothing seems to made it through to the stock Fedora kernel.

Have I missed something, or is there a roadblock somewhere?

I ask as I haven't allowed any updates through since November last and 
they're piling up somewhat.

Andy M

On 11/11/2015 11:48 AM, Mauro Carvalho Chehab wrote:
> This patch broke ivtv logic, as reported at
>   https://bugzilla.redhat.com/show_bug.cgi?id=1278942
>
> This reverts commit 09290cc885937cab3b2d60a6d48fe3d2d3e04061.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>
> diff --git a/drivers/media/pci/ivtv/ivtv-driver.c b/drivers/media/pci/ivtv/ivtv-driver.c
> index 3a6f668b14b8..21501c560610 100644
> --- a/drivers/media/pci/ivtv/ivtv-driver.c
> +++ b/drivers/media/pci/ivtv/ivtv-driver.c
> @@ -805,11 +805,11 @@ static void ivtv_init_struct2(struct ivtv *itv)
>   {
>   	int i;
>
> -	for (i = 0; i < IVTV_CARD_MAX_VIDEO_INPUTS - 1; i++)
> +	for (i = 0; i < IVTV_CARD_MAX_VIDEO_INPUTS; i++)
>   		if (itv->card->video_inputs[i].video_type == 0)
>   			break;
>   	itv->nof_inputs = i;
> -	for (i = 0; i < IVTV_CARD_MAX_AUDIO_INPUTS - 1; i++)
> +	for (i = 0; i < IVTV_CARD_MAX_AUDIO_INPUTS; i++)
>   		if (itv->card->audio_inputs[i].audio_type == 0)
>   			break;
>   	itv->nof_audio_inputs = i;
>


-- 
Andrew Meredith CEng CITP

      parent reply	other threads:[~2016-01-27 16:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 11:48 [PATCH 1/2] Revert "[media] ivtv: avoid going past input/audio array" Mauro Carvalho Chehab
2015-11-11 11:48 ` [PATCH 2/2] [media] ivtv: avoid going past input/audio array As reported by smatch: drivers/media/pci/ivtv/ivtv-driver.c:832 ivtv_init_struct2() error: buffer overflow 'itv->card->video_inputs' 6 <= 6 Mauro Carvalho Chehab
2016-01-27 16:28 ` Andrew Meredith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A8F049.9000705@anvil.org \
    --to=andrew@anvil.org \
    --cc=awalls@md.metrocast.net \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mchehab@osg.samsung.com \
    --cc=warren.sturm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.