Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type

[Grygorii Strashko <grygorii.strashko@ti.com>]

On 01/27/2016 03:56 PM, Linus Walleij wrote:
> On Wed, Dec 30, 2015 at 3:16 PM, Geliang Tang <geliangtang@163.com> wrote:
>
>> Use irq_data_get_chip_type() instead of container_of().
>>
>> Signed-off-by: Geliang Tang <geliangtang@163.com>
>> ---
>>   drivers/gpio/gpio-davinci.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index 65ebaef..aaa1a249 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -435,8 +435,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
>>   {
>>          static struct irq_chip_type gpio_unbanked;
>>
>> -       gpio_unbanked = *container_of(irq_get_chip(irq),
>> -                                     struct irq_chip_type, chip);
>> +       gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
>>
>>          return &gpio_unbanked.chip;
>>   };
>
> Grygorii/Santosh, can you ACK/comment on this patch?
>

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>


-- 
regards,
-grygorii