All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org
Cc: riku.voipio@linaro.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: Move qemu-binfmt-conf.sh to Debian model
Date: Wed, 27 Jan 2016 21:45:59 +0300	[thread overview]
Message-ID: <56A91067.7010709@msgid.tls.msk.ru> (raw)
In-Reply-To: <1453903855-4569-1-git-send-email-agraf@suse.de>

27.01.2016 17:10, Alexander Graf wrote:
> The qemu-binfmt-conf.sh script has been pretty unmaintained for most of its
> time. The reason is simply that few distributions actually use the file as
> is.

Heh.  I always tried to follow qemu-binfmt-conf.sh in our debian work :)
Granted, later I checked linux-user/main.c (IIRC), too.

> This patch takes the Debian approach to registering binfmt handlers:
> 
>   https://packages.debian.org/en/sid/qemu-user-binfmt

I had a plan to generalize this before next centurity.  The thing is that most
of the formats and masks are the same, the difference is in the endianness,
word size and the architecture.  It might be easier to generate the masks
from the tuples, putting thme 3 fields into places and keepin the rest
the same.  But I haven't got to doing that, so far... :)

See also the fat comment about SYSV vs GNU/LINUX OSABI which needs to
be fixed -- after switching to tuples from masks it will be easier.

> and moves that code into our script, maintaining backwards compatibility with
> its previous calling scheme. The major benefit of this is that now Debian can
> just do
> 
>   HOST_ARCH=$DPKG_MAINTSCRIPT_ARCH
>   QEMU_BINFMT_SKIP_REGISTRATION=1
>   . /path/to/qemu-binfmt-conf.sh
> 
> and get the exact same binfmt configuration as the upstream script, hopefully
> ensuring that in the future the upstream version becomes the maintained one.

I don't think it will work in practice, at least before some good thinking :)
It was a quick hack to generalize things like this, and as per above it needs
some more work (at least to fix the OSABI issue).

But might be it is better than nothing anyway... :)  Provided it is actually
useful, -- do you think it is?

Thanks,

/mjt

  reply	other threads:[~2016-01-27 18:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-27 14:10 [Qemu-devel] [PATCH] linux-user: Move qemu-binfmt-conf.sh to Debian model Alexander Graf
2016-01-27 18:45 ` Michael Tokarev [this message]
2016-01-27 18:54   ` Peter Maydell
2016-01-28 18:56     ` Alexander Graf
2016-01-28 19:08       ` Peter Maydell
2016-01-28 19:16 ` Laurent Vivier
2016-01-28 19:22   ` Alexander Graf
2016-01-28 19:27     ` Laurent Vivier
2016-01-28 19:35       ` Alexander Graf
2016-01-28 19:36         ` Peter Maydell
2016-01-28 19:40           ` Laurent Vivier
2016-01-28 19:45             ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A91067.7010709@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.