From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Hackmann Subject: Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Date: Wed, 27 Jan 2016 13:41:03 -0800 Message-ID: <56A9396F.8010803@google.com> References: <1453901439-19467-1-git-send-email-gustavo@padovan.org> <1453901439-19467-2-git-send-email-gustavo@padovan.org> <56A8D4A7.1070409@linux.intel.com> <20160127170313.GC3773@joana> <20160127202540.GD3773@joana> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA5EA6E765 for ; Wed, 27 Jan 2016 13:41:08 -0800 (PST) Received: by mail-pa0-f51.google.com with SMTP id uo6so11218834pac.1 for ; Wed, 27 Jan 2016 13:41:08 -0800 (PST) In-Reply-To: <20160127202540.GD3773@joana> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , Emil Velikov , Maarten Lankhorst , Greg Kroah-Hartman , "Linux-Kernel@Vger. Kernel. Org" , devel@driverdev.osuosl.org, ML dri-devel , Daniel Stone , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Daniel Vetter , Rob Clark , John Harrison , Gustavo Padovan List-Id: dri-devel@lists.freedesktop.org T24gMDEvMjcvMjAxNiAxMjoyNSBQTSwgR3VzdGF2byBQYWRvdmFuIHdyb3RlOgo+Pj4+IElzIHRo ZXJlIGEgdmFsdWUgaW4ga2VlcGluZyB0aGUgYWJpIHVuY2hhbmdlZD8KPj4+PiBJZiBub3QsIHRo ZW4gRG9jdW1lbnRhdGlvbi9pb2N0bC9ib3RjaGluZy11cC1pb2N0bHMudHh0IGlzIHdvcnRoIGEg cmVhZC4KPj4+Cj4+PiBOb25lIGZyb20gbWUuIEknbGwgbG9vayB3aGVyZSB3ZSBjYW4gaW1wcm92 ZSB0aGUgQUJJLgoKQW5kcm9pZCBoYXMgZXhpc3RpbmcgY2xpZW50cyBvZiB0aGUgY3VycmVudCBB QkkuICBUaGFua2Z1bGx5IHRoZXkncmUgYWxsIApjb250YWluZWQgaW4gc3lzdGVtIHNlcnZpY2Vz IGxpa2UgU3VyZmFjZUZsaW5nZXIsIHNpbmNlIGVuZC11c2VyIGFwcHMgCmRvbid0IGdldCBkaXJl Y3QgYWNjZXNzIHRvIGZlbmNlIGZkcy4KCkFzIGxvbmcgdGhlIEFCSSBicmVha3MgZG9uJ3QgcmVt b3ZlIGZ1bmN0aW9uYWxpdHkgd2UgZGVwZW5kIG9uLCB3ZSBjYW4gCndyYXAgYXJvdW5kIHRoZW0g aW4gb3VyIHVzZXJzcGFjZSBsaWJzeW5jLiAgSSdkIHJhdGhlciBub3QgaGF2ZSB0byBkbyAKdGhh dCwgYnV0IGl0J3MgYSBwcmljZSBJJ20gd2lsbGluZyB0byBwYXkgdG8gZ2V0IHRoaXMgbW92ZWQg b3V0IG9mIHN0YWdpbmcuCgo+PiAgIC0gc3RydWN0IHN5bmNfZmlsZV9pbmZvX2RhdGE6OmZlbmNl X2luZm8gaXMgb2YgdHlwZSBfX3U4IHlldCBpdCBpcyAiYQo+PiBmZW5jZV9pbmZvIHN0cnVjdCBm b3IgZXZlcnkgZmVuY2UgaW4gdGhlIHN5bmNfZmlsZSIuIFRodXMgc2hvdWxkbid0Cj4+IG9uZSB1 c2UgInN0cnVjdCBmZW5jZV9pbmZvIiBhcyB0aGUgdHlwZSA/Cj4KPiBBZ3JlZWQuIEJ1dCBJJ20g Y3VycmVudGx5IHRoaW5raW5nIGlmIHdlIHJlYWxseSBzaG91bGQga2VlcCB0aGlzIGlvY3RsLgo+ Cj4gCUd1c3Rhdm8KPgoKSSdtIG5vdCBzZWVpbmcgYW55IGNvbnN1bWVycyBvZiBkcml2ZXJfZGF0 YSBpbiBvdXIgdHJlZS4gIE9UT0ggCmNvbXBsZXRlbHkgZ2V0dGluZyByaWQgb2YgdGhlIGlvY3Rs IHdvdWxkIGJlIGEgcHJvYmxlbSwgc2luY2UgClN1cmZhY2VGbGluZ2VyIGRlcGVuZHMgb24gdGhl IHRpbWVzdGFtcCBpbmZvcm1hdGlvbiBmb3IgaXRzIG93biBib29ra2VlcGluZy4KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936192AbcA0VlQ (ORCPT ); Wed, 27 Jan 2016 16:41:16 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33775 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935244AbcA0VlJ (ORCPT ); Wed, 27 Jan 2016 16:41:09 -0500 Subject: Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file To: Gustavo Padovan , Emil Velikov , Maarten Lankhorst , Greg Kroah-Hartman , "Linux-Kernel@Vger. Kernel. Org" , devel@driverdev.osuosl.org, ML dri-devel , Daniel Stone , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Daniel Vetter , Rob Clark , John Harrison , Gustavo Padovan References: <1453901439-19467-1-git-send-email-gustavo@padovan.org> <1453901439-19467-2-git-send-email-gustavo@padovan.org> <56A8D4A7.1070409@linux.intel.com> <20160127170313.GC3773@joana> <20160127202540.GD3773@joana> From: Greg Hackmann Message-ID: <56A9396F.8010803@google.com> Date: Wed, 27 Jan 2016 13:41:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160127202540.GD3773@joana> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/27/2016 12:25 PM, Gustavo Padovan wrote: >>>> Is there a value in keeping the abi unchanged? >>>> If not, then Documentation/ioctl/botching-up-ioctls.txt is worth a read. >>> >>> None from me. I'll look where we can improve the ABI. Android has existing clients of the current ABI. Thankfully they're all contained in system services like SurfaceFlinger, since end-user apps don't get direct access to fence fds. As long the ABI breaks don't remove functionality we depend on, we can wrap around them in our userspace libsync. I'd rather not have to do that, but it's a price I'm willing to pay to get this moved out of staging. >> - struct sync_file_info_data::fence_info is of type __u8 yet it is "a >> fence_info struct for every fence in the sync_file". Thus shouldn't >> one use "struct fence_info" as the type ? > > Agreed. But I'm currently thinking if we really should keep this ioctl. > > Gustavo > I'm not seeing any consumers of driver_data in our tree. OTOH completely getting rid of the ioctl would be a problem, since SurfaceFlinger depends on the timestamp information for its own bookkeeping.