From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60323)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhangchen.fnst@cn.fujitsu.com>) id 1aObI5-0003Jk-Ug
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 20:22:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhangchen.fnst@cn.fujitsu.com>) id 1aObI1-0006zY-P3
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 20:22:29 -0500
Received: from [59.151.112.132] (port=24875 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhangchen.fnst@cn.fujitsu.com>) id 1aObI1-0006yk-BR
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 20:22:25 -0500
References: <1453798787-7453-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<56A812E9.9030006@huawei.com> <56A8EC09.8070906@redhat.com>
From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Message-ID: <56A96D3A.6090708@cn.fujitsu.com>
Date: Thu, 28 Jan 2016 09:22:02 +0800
MIME-Version: 1.0
In-Reply-To: <56A8EC09.8070906@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] net/traffic-mirrorer:Add traffic-mirroer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Hailiang Zhang <zhang.zhanghailiang@huawei.com>, qemu devel <qemu-devel@nongnu.org>, Jason Wang <jasowang@redhat.com>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>, Gui jianfeng <guijianfeng@cn.fujitsu.com>, "eddie.dong" <eddie.dong@intel.com>, peter.huangpeng@huawei.com, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Yang Hongyang <hongyang.yang@easystack.cn>



On 01/28/2016 12:10 AM, Eric Blake wrote:
> On 01/26/2016 05:44 PM, Hailiang Zhang wrote:
>> On 2016/1/26 16:59, Zhang Chen wrote:
>>> From: ZhangChen <zhangchen.fnst@cn.fujitsu.com>
>>>
>>> Traffic-mirrorer is a plugin of netfilter.
>>> It make qemu has ability to copy and mirror guest's
>>> net packet. we output packet to chardev.
>>>
>>> +static void traffic_mirrorer_setup(NetFilterState *nf, Error **errp)
>>> +{
>>> +    MirrorerState *s = FILTER_TRAFFIC_MIRRORER(nf);
>>> +
>>> +    if (!s->outdev) {
>>> +        error_setg(errp, "filter traffic mirrorer needs 'outdev'
>>> property set!"
>>> +                "property set!");
>> Duplicate 'property set!'.
> For that matter, error_setg() messages should never end in '!'.
>

Thanks, I will fix it in V3
zhangchen


-- 
Thanks
zhangchen