From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangkefeng.wang@huawei.com (Kefeng Wang) Date: Thu, 28 Jan 2016 09:41:23 +0800 Subject: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" In-Reply-To: References: <1453868872-26300-1-git-send-email-wangkefeng.wang@huawei.com> <1453868872-26300-15-git-send-email-wangkefeng.wang@huawei.com> Message-ID: <56A971C3.6000608@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Masahiro, On 2016/1/27 21:48, Masahiro Yamada wrote: > 2016-01-27 13:27 GMT+09:00 Kefeng Wang : >> This reverts commit 326ea45aa827da6686c78b5907f9839f91ef5782. >> >> After covering to use helper of_platform_default_populate() to >> populate the default bus, no error in build uniphier driver as >> a module. > > This statement is weird. > There is no error for building this driver as a module > at the point of v4.5-rc1. Yes, but after drop export of_default_bus_match_table in patchset(15/15), we will meet build issue, so the statement can be changed to ------------ After covering to use helper of_platform_default_populate() to populate the default bus, this driver can be safely as a tristate one, no error in build uniphier driver as a module once we drop export of_default_bus_match_table in later patch. ------------ > > The of_platform_default_populate() conversion (11/15) is unrelated > to fixing the build error. > > BTW, I had already posted an equivalent patch a few days before: > > https://patchwork.kernel.org/patch/8096991/ > I didn't notice this before, it is ok for me to use your patch, or I will send a new one with update changlog, thanks for your review. > > > >> Cc: Masahiro Yamada >> Cc: Arnd Bergmann >> Signed-off-by: Kefeng Wang >> --- >> drivers/bus/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig >> index 129d47b..9a92c07 100644 >> --- a/drivers/bus/Kconfig >> +++ b/drivers/bus/Kconfig >> @@ -132,7 +132,7 @@ config SUNXI_RSB >> and AC100/AC200 ICs. >> >> config UNIPHIER_SYSTEM_BUS >> - bool "UniPhier System Bus driver" >> + tristate "UniPhier System Bus driver" >> depends on ARCH_UNIPHIER && OF >> default y >> help >> -- >> 2.6.0.GIT >> > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967368AbcA1Bmb (ORCPT ); Wed, 27 Jan 2016 20:42:31 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:35889 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934002AbcA1Bm3 (ORCPT ); Wed, 27 Jan 2016 20:42:29 -0500 Subject: Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" To: Masahiro Yamada References: <1453868872-26300-1-git-send-email-wangkefeng.wang@huawei.com> <1453868872-26300-15-git-send-email-wangkefeng.wang@huawei.com> CC: Linux Kernel Mailing List , linux-arm-kernel , Arnd Bergmann , Shawn Guo , Russell King , Catalin Marinas , Hauke Mehrtens , Rob Herring , From: Kefeng Wang Message-ID: <56A971C3.6000608@huawei.com> Date: Thu, 28 Jan 2016 09:41:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.56A971CF.0152,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 3a643570b2480a2d43c5c987a08725bd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, On 2016/1/27 21:48, Masahiro Yamada wrote: > 2016-01-27 13:27 GMT+09:00 Kefeng Wang : >> This reverts commit 326ea45aa827da6686c78b5907f9839f91ef5782. >> >> After covering to use helper of_platform_default_populate() to >> populate the default bus, no error in build uniphier driver as >> a module. > > This statement is weird. > There is no error for building this driver as a module > at the point of v4.5-rc1. Yes, but after drop export of_default_bus_match_table in patchset(15/15), we will meet build issue, so the statement can be changed to ------------ After covering to use helper of_platform_default_populate() to populate the default bus, this driver can be safely as a tristate one, no error in build uniphier driver as a module once we drop export of_default_bus_match_table in later patch. ------------ > > The of_platform_default_populate() conversion (11/15) is unrelated > to fixing the build error. > > BTW, I had already posted an equivalent patch a few days before: > > https://patchwork.kernel.org/patch/8096991/ > I didn't notice this before, it is ok for me to use your patch, or I will send a new one with update changlog, thanks for your review. > > > >> Cc: Masahiro Yamada >> Cc: Arnd Bergmann >> Signed-off-by: Kefeng Wang >> --- >> drivers/bus/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig >> index 129d47b..9a92c07 100644 >> --- a/drivers/bus/Kconfig >> +++ b/drivers/bus/Kconfig >> @@ -132,7 +132,7 @@ config SUNXI_RSB >> and AC100/AC200 ICs. >> >> config UNIPHIER_SYSTEM_BUS >> - bool "UniPhier System Bus driver" >> + tristate "UniPhier System Bus driver" >> depends on ARCH_UNIPHIER && OF >> default y >> help >> -- >> 2.6.0.GIT >> > >