From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH V1 1/1] jobstats: added function abort for job Date: Thu, 28 Jan 2016 09:41:06 +0200 Message-ID: <56A9C612.3080502@redhat.com> References: <1453824934-10650-1-git-send-email-marcinx.kerlin@intel.com> <56A8C82C.3080107@redhat.com> <60ABE07DBB3A454EB7FAD707B4BB158213A1DC96@IRSMSX109.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: "Jastrzebski, MichalX K" , "Kerlin, MarcinX" , "dev@dpdk.org" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 109CBC356 for ; Thu, 28 Jan 2016 08:41:08 +0100 (CET) In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB158213A1DC96@IRSMSX109.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/27/2016 05:57 PM, Jastrzebski, MichalX K wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen >> Sent: Wednesday, January 27, 2016 2:38 PM >> To: Kerlin, MarcinX ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH V1 1/1] jobstats: added function abort for job >> >> On 01/26/2016 06:15 PM, Marcin Kerlin wrote: >>> This patch adds new function rte_jobstats_abort. It marks *job* as finished >>> and time of this work will be add to management time instead of execution >> time. >>> This function should be used instead of rte_jobstats_finish if condition >> occure, >>> condition is defined by the application for example when receiving n>0 >> packets. >>> >>> Signed-off-by: Marcin Kerlin >>> --- >>> lib/librte_jobstats/rte_jobstats.c | 22 ++++++++++++++++++++++ >>> lib/librte_jobstats/rte_jobstats.h | 17 +++++++++++++++++ >>> lib/librte_jobstats/rte_jobstats_version.map | 7 +++++++ >>> 3 files changed, 46 insertions(+) >>> >> [...] >>> diff --git a/lib/librte_jobstats/rte_jobstats.h >> b/lib/librte_jobstats/rte_jobstats.h >>> index de6a89a..9995319 100644 >>> --- a/lib/librte_jobstats/rte_jobstats.h >>> +++ b/lib/librte_jobstats/rte_jobstats.h >>> @@ -90,6 +90,9 @@ struct rte_jobstats { >>> uint64_t exec_cnt; >>> /**< Execute count. */ >>> >>> + uint64_t last_job_time; >>> + /**< Last job time */ >>> + >>> char name[RTE_JOBSTATS_NAMESIZE]; >>> /**< Name of this job */ >>> >> >> AFAICS this is an ABI break and as such, needs to be preannounced, see >> http://dpdk.org/doc/guides/contributing/versioning.html >> For 2.3 it'd need to be a CONFIG_RTE_NEXT_ABI feature. >> >> - Panu - > > Hi Panu, > Thanks for Your notice. This last_job_time field is actually not necessary here > and will be removed from this structure. Right, makes sense. You can always add it later on when there's a more pressing need to break the ABI. - Panu -