From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42242)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aOkWV-00076p-AQ
	for qemu-devel@nongnu.org; Thu, 28 Jan 2016 06:14:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aOkWS-0002JK-KV
	for qemu-devel@nongnu.org; Thu, 28 Jan 2016 06:13:59 -0500
Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:35113)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aOkWS-0002J5-Dk
	for qemu-devel@nongnu.org; Thu, 28 Jan 2016 06:13:56 -0500
Received: by mail-wm0-x243.google.com with SMTP id l66so3018956wml.2
	for <qemu-devel@nongnu.org>; Thu, 28 Jan 2016 03:13:56 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1453976119-24372-1-git-send-email-alex.bennee@linaro.org>
	<1453976119-24372-3-git-send-email-alex.bennee@linaro.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56A9F7F1.7070903@redhat.com>
Date: Thu, 28 Jan 2016 12:13:53 +0100
MIME-Version: 1.0
In-Reply-To: <1453976119-24372-3-git-send-email-alex.bennee@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v1 2/5] configure: ensure ldflags
 propagated to config_host
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: mttcg@listserver.greensocs.com, peter.maydell@linaro.org, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, stefanha@redhat.com, fred.konrad@greensocs.com



On 28/01/2016 11:15, Alex Bennée wrote:
> diff --git a/configure b/configure
> index bd29ba7..148b79a 100755
> --- a/configure
> +++ b/configure
> @@ -5871,7 +5871,7 @@ if test "$target_linux_user" = "yes" -o "$target_bsd_user" = "yes" ; then
>    ldflags="$ldflags $textseg_ldflags"
>  fi
>  
> -echo "LDFLAGS+=$ldflags" >> $config_target_mak
> +echo "LDFLAGS+=$ldflags" >> $config_host_mak
>  echo "QEMU_CFLAGS+=$cflags" >> $config_target_mak
>  
>  done # for target in $targets

Hmm wait, it's not okay.

This adds the *target* LDFLAGS to config-host.mak, and adds them a
zillion times.  extra-ldflags is already added to LDFLAGS in
config-host.mak:

  --extra-ldflags=*) LDFLAGS="$LDFLAGS $optarg"
                     EXTRA_LDFLAGS="$optarg"
  ;;

...

echo "LDFLAGS=$LDFLAGS" >> $config_host_mak

So I'm totally confused as to what this patch is trying to achieve...

Paolo