From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamil Rytarowski Subject: Re: [PATCH v5 1/2] tools: Add support for handling built-in kernel modules Date: Thu, 28 Jan 2016 12:16:44 +0100 Message-ID: <56A9F89C.1060800@caviumnetworks.com> References: <1449588833-485-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com> <1540084.9SflLyUVmh@xps13> <569E65ED.9060007@caviumnetworks.com> <3408742.MAgGxnHKYz@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0099.outbound.protection.outlook.com [65.55.169.99]) by dpdk.org (Postfix) with ESMTP id AE7BAC37C for ; Thu, 28 Jan 2016 12:16:59 +0100 (CET) In-Reply-To: <3408742.MAgGxnHKYz@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 26.01.2016 o 16:12, Thomas Monjalon pisze: > 2016-01-19 17:35, Kamil Rytarowski: >> W dniu 18.01.2016 o 15:32, Thomas Monjalon pisze: >>> Hi Kamil, >>> >>> 2015-12-09 14:19, Kamil Rytarowski: >>>> Currently dpdk_nic_bind.py detects Linux kernel modules via reading >>>> /proc/modules. Built-in ones aren't listed there and therefore they are not >>>> being found by the script. >>>> >>>> Add support for checking built-in modules with parsing the sysfs files. >>>> >>>> This commit obsoletes the /proc/modules parsing approach. >>>> >>>> Signed-off-by: Kamil Rytarowski >>> I have a doubt about this tag: >>>> Signed-off-by: David Marchand >>> What do you mean here? >> Excuse me, it should be: Acked-by: David Marchand >> >> >> http://dpdk.org/ml/archives/dev/2015-December/029720.html > The ack was only for the patch 2/2 I see. I will correct it.