From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kamil Rytarowski <krytarowski@caviumnetworks.com>
Subject: Re: [PATCH v6 1/2] tools: Add support for handling
 built-in kernel modules
Date: Thu, 28 Jan 2016 12:17:39 +0100
Message-ID: <56A9F8D3.3010605@caviumnetworks.com>
References: <1449667198-27218-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com>
 <1453283317-1078-1-git-send-email-krytarowski@caviumnetworks.com>
 <1872674.ygjbT6ghrC@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from na01-bl2-obe.outbound.protection.outlook.com
 (mail-bl2on0084.outbound.protection.outlook.com [65.55.169.84])
 by dpdk.org (Postfix) with ESMTP id 4C39DC444
 for <dev@dpdk.org>; Thu, 28 Jan 2016 12:17:54 +0100 (CET)
In-Reply-To: <1872674.ygjbT6ghrC@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



W dniu 26.01.2016 o 16:23, Thomas Monjalon pisze:
> 2016-01-20 10:48, krytarowski@caviumnetworks.com:
>> --- a/tools/dpdk_nic_bind.py
>> +++ b/tools/dpdk_nic_bind.py
>> -    for line in loaded_mods:
>> +    try:
>> +        # Get list of syfs modules, some of them might be builtin and merge with mods
> Please could you explain this comment?
> Is it remaining from previous versions of the patch?

Yes. It might be changed to:
# Get list of sysfs modules (both built-in and dynamically loaded)

> [...]
>> +        # special case for vfio_pci (module is named vfio-pci,
>> +        # but its .ko is named vfio_pci)
> Isn't it common to have dash replaced by underscore for kernel modules?
>

I retained the logic for special case of vfio-pci. At the moment 
(according to my knowledge) there are no other DPDK modules with this 
name replacement.

I checked few example Linux modules and if a module is named with dash, 
it's being replaced to underscore. The modprobe(8) tool can accept both 
names as interchangeable (with dash and underscore).

Would you like to make it a general rule and replace all dashes with 
underscores?

Thank you