From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kamil Rytarowski <krytarowski@caviumnetworks.com>
Subject: Re: [PATCH v6 1/2] tools: Add support for handling
 built-in kernel modules
Date: Thu, 28 Jan 2016 13:54:05 +0100
Message-ID: <56AA0F6D.3080702@caviumnetworks.com>
References: <1449667198-27218-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com>
 <1453283317-1078-1-git-send-email-krytarowski@caviumnetworks.com>
 <1872674.ygjbT6ghrC@xps13> <56A9F8D3.3010605@caviumnetworks.com>
 <56A9F9EB.4090906@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Panu Matilainen <pmatilai@redhat.com>, Thomas Monjalon
 <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from na01-bl2-obe.outbound.protection.outlook.com
 (mail-bl2on0067.outbound.protection.outlook.com [65.55.169.67])
 by dpdk.org (Postfix) with ESMTP id 98A9EC3BA
 for <dev@dpdk.org>; Thu, 28 Jan 2016 13:54:25 +0100 (CET)
In-Reply-To: <56A9F9EB.4090906@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



W dniu 28.01.2016 o 12:22, Panu Matilainen pisze:
> On 01/28/2016 01:17 PM, Kamil Rytarowski wrote:
>> I retained the logic for special case of vfio-pci. At the moment
>> (according to my knowledge) there are no other DPDK modules with this
>> name replacement.
>>
>> I checked few example Linux modules and if a module is named with dash,
>> it's being replaced to underscore. The modprobe(8) tool can accept both
>> names as interchangeable (with dash and underscore).
>>
>> Would you like to make it a general rule and replace all dashes with
>> underscores?
>
> It would be nice to behave the same as modprobe wrt dash and 
> underscore, yes.
>
>     - Panu -
>

My patch is intended to support built-in modules, the rest isn't that 
trivial without changing the behavior.

I prototyped it and it added extra unnecessary complexity, while we just 
want to handle vfio_pci -> vfio-pci.

I'm going to submit new version with improved comment in the code. 
Please continue possible improvements in separate threads.