From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call Date: Thu, 28 Jan 2016 16:18:21 +0200 Message-ID: <56AA232D.3040509@ti.com> References: <1453988331-17111-1-git-send-email-j-keerthy@ti.com> <1453988331-17111-2-git-send-email-j-keerthy@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:39872 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755414AbcA1OSh (ORCPT ); Thu, 28 Jan 2016 09:18:37 -0500 In-Reply-To: <1453988331-17111-2-git-send-email-j-keerthy@ti.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Keerthy , linus.walleij@linaro.org, Alexandre Courbot Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, lokeshvutla@ti.com, Santosh Shilimkar , Sekhar Nori On 01/28/2016 03:38 PM, Keerthy wrote: > Currently the first parameter of irq_domain_add_legacy is NULL. > irq_find_host function returns NULL when we do not populate the of_node > and hence irq_of_parse_and_map call fails whenever we want to request a > gpio irq. This fixes the request_irq failures for gpio interrupts. > > Signed-off-by: Keerthy Reviewed-by: Grygorii Strashko > --- > drivers/gpio/gpio-davinci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c > index ec58f42..c889f31 100644 > --- a/drivers/gpio/gpio-davinci.c > +++ b/drivers/gpio/gpio-davinci.c > @@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) > return irq; > } > > - irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0, > + irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0, > &davinci_gpio_irq_ops, > chips); > if (!irq_domain) { > -- regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755500AbcA1OTf (ORCPT ); Thu, 28 Jan 2016 09:19:35 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:39872 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755414AbcA1OSh (ORCPT ); Thu, 28 Jan 2016 09:18:37 -0500 Subject: Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call To: Keerthy , , Alexandre Courbot References: <1453988331-17111-1-git-send-email-j-keerthy@ti.com> <1453988331-17111-2-git-send-email-j-keerthy@ti.com> CC: , , , Santosh Shilimkar , Sekhar Nori From: Grygorii Strashko Message-ID: <56AA232D.3040509@ti.com> Date: Thu, 28 Jan 2016 16:18:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1453988331-17111-2-git-send-email-j-keerthy@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/28/2016 03:38 PM, Keerthy wrote: > Currently the first parameter of irq_domain_add_legacy is NULL. > irq_find_host function returns NULL when we do not populate the of_node > and hence irq_of_parse_and_map call fails whenever we want to request a > gpio irq. This fixes the request_irq failures for gpio interrupts. > > Signed-off-by: Keerthy Reviewed-by: Grygorii Strashko > --- > drivers/gpio/gpio-davinci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c > index ec58f42..c889f31 100644 > --- a/drivers/gpio/gpio-davinci.c > +++ b/drivers/gpio/gpio-davinci.c > @@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) > return irq; > } > > - irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0, > + irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0, > &davinci_gpio_irq_ops, > chips); > if (!irq_domain) { > -- regards, -grygorii