From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH] vm_event: make sure the domain is paused in
 key domctls
Date: Thu, 28 Jan 2016 16:27:31 +0200
Message-ID: <56AA2553.3030707@bitdefender.com>
References: <1453989160-8002-1-git-send-email-rcojocaru@bitdefender.com>
	<56AA215E.5020605@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56AA215E.5020605@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org
Cc: tamas@tklengyel.com, keir@xen.org, jbeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

On 01/28/2016 04:10 PM, Andrew Cooper wrote:
> On 28/01/16 13:52, Razvan Cojocaru wrote:
>> This patch pauses the domain for all writes through the 'ad'
>> pointer in monitor_domctl(), defers a domain_unpause() call until
>> after the CRs are updated for the MONITOR_EVENT_WRITE_CTRLREG
>> case, and makes sure that the domain is paused for both vm_event
>> enable and disable cases in vm_event_domctl().
>> Thanks go to Andrew Cooper for his review and suggestions.
>>
>> Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
> 
> Would you mind annotating each of the checks for d != current->domain
> with /* no domain_pause(). */, which is our normal practice.

Of course, no problem.

> I think it might be better to move the current check for
> XEN_DOMCTL_monitor_op into monitor_domctl() itself, to have all checks
> together in one place.

I'll move it.

>> @@ -144,6 +146,8 @@ int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop)
>>          if ( rc )
>>              return rc;
>>  
>> +        domain_pause(d);
>> +
>>          if ( mop->op == XEN_DOMCTL_MONITOR_OP_ENABLE &&
>>               mop->u.mov_to_msr.extended_capture )
>>          {
>> @@ -154,7 +158,6 @@ int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop)
> 
> You will need to rework the return -EOPNOTSUPP between these two hunks
> to avoid missing the domain_unpause()
> 
> It would probably be better to pull the check forwards to before the
> domain_pause().

Right, sorry I've missed that. Thanks!

>>          } else
>>              ad->monitor.mov_to_msr_extended = 0;
>>  
>> -        domain_pause(d);
>>          ad->monitor.mov_to_msr_enabled = !status;
>>          domain_unpause(d);
>>          break;
>> @@ -196,9 +199,8 @@ int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop)
>>
> 
> The other codepaths look fine.


Thanks for the review,
Razvan