From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966820AbcA1PVU (ORCPT ); Thu, 28 Jan 2016 10:21:20 -0500 Received: from mail113-250.mail.alibaba.com ([205.204.113.250]:39089 "EHLO us-alimail-mta1.hst.scl.en.alidc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965255AbcA1PVS (ORCPT ); Thu, 28 Jan 2016 10:21:18 -0500 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07488559|-1;FP=0|0|0|0|0|-1|-1|-1;HT=e01l04447;MF=chengang@emindsoft.com.cn;NM=1;PH=DS;RN=8;RT=8;SR=0;TI=SMTPD_----4Ueey6c_1453994427; Message-ID: <56AA3293.4010601@emindsoft.com.cn> Date: Thu, 28 Jan 2016 23:24:03 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Heiko Carstens CC: akpm@linux-foundation.org, dhowells@redhat.com, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com, josh@joshtriplett.org, Chen Gang Subject: Re: [PATCH] include/linux/list_bl.h: Use bool instead of int for boolean functions References: <1453669098-8595-1-git-send-email-chengang@emindsoft.com.cn> <20160128072236.GA5067@osiris> In-Reply-To: <20160128072236.GA5067@osiris> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/28/16 15:22, Heiko Carstens wrote: > On Mon, Jan 25, 2016 at 04:58:18AM +0800, chengang@emindsoft.com.cn wrote: >> From: Chen Gang >> >> hlist_bl_unhashed() and hlist_bl_empty() are all boolean functions, so >> return bool instead of int. >> >> Signed-off-by: Chen Gang >> --- >> include/linux/list_bl.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/list_bl.h b/include/linux/list_bl.h >> index ee7229a..cb48330 100644 >> --- a/include/linux/list_bl.h >> +++ b/include/linux/list_bl.h >> @@ -48,7 +48,7 @@ static inline void INIT_HLIST_BL_NODE(struct hlist_bl_node *h) >> >> #define hlist_bl_entry(ptr, type, member) container_of(ptr,type,member) >> >> -static inline int hlist_bl_unhashed(const struct hlist_bl_node *h) >> +static inline bool hlist_bl_unhashed(const struct hlist_bl_node *h) >> { >> return !h->pprev; >> } >> @@ -68,7 +68,7 @@ static inline void hlist_bl_set_first(struct hlist_bl_head *h, >> h->first = (struct hlist_bl_node *)((unsigned long)n | LIST_BL_LOCKMASK); >> } >> >> -static inline int hlist_bl_empty(const struct hlist_bl_head *h) >> +static inline bool hlist_bl_empty(const struct hlist_bl_head *h) >> { >> return !((unsigned long)READ_ONCE(h->first) & ~LIST_BL_LOCKMASK); > > Sorry for my ignorance, but what's the point of doing conversions like > this? It has zero impact on code generation. > For me, in our case, the 2 functions really generate boolean value, and they are really used as boolean functions, so returning boolean value will let the code a little simpler and a little clearer. Thanks. -- Chen Gang (陈刚) Open, share, and attitude like air, water, and life which God blessed