From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: shmobile: Move shmobile_scu_base from .text to .data
Date: Thu, 28 Jan 2016 18:37:19 +0300 [thread overview]
Message-ID: <56AA35AF.8080601@cogentembedded.com> (raw)
In-Reply-To: <1453993462-12210-2-git-send-email-geert+renesas@glider.be>
Hello.
On 01/28/2016 06:04 PM, Geert Uytterhoeven wrote:
> shmobile_scu_base is being written to, so it doesn't belong in the .text
> section. Fix this by moving it from asm .text to C .data, as it's no
> longer used from asm code since commit 4f6da36f7edd5790 ("ARM: shmobile:
> Remove old SCU boot code").
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
[...]
> diff --git a/arch/arm/mach-shmobile/platsmp-scu.c b/arch/arm/mach-shmobile/platsmp-scu.c
> index 64663110ab6ca0e1..f2198c9c74359736 100644
> --- a/arch/arm/mach-shmobile/platsmp-scu.c
> +++ b/arch/arm/mach-shmobile/platsmp-scu.c
> @@ -17,6 +17,9 @@
> #include <asm/smp_scu.h>
> #include "common.h"
>
> +
Why add 2nd empty line?
> +void __iomem *shmobile_scu_base;
> +
> static int shmobile_smp_scu_notifier_call(struct notifier_block *nfb,
> unsigned long action, void *hcpu)
> {
MBR, Sergei
next prev parent reply other threads:[~2016-01-28 15:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 15:04 [PATCH 0/2] ARM: shmobile: Move written variables from .text to .data Geert Uytterhoeven
2016-01-28 15:04 ` [PATCH 1/2] ARM: shmobile: Move shmobile_scu_base " Geert Uytterhoeven
2016-01-28 15:37 ` Sergei Shtylyov [this message]
2016-01-28 17:00 ` Geert Uytterhoeven
2016-01-28 15:04 ` [PATCH 2/2] ARM: shmobile: Move shmobile_smp_{mpidr, fn, arg}[] " Geert Uytterhoeven
2016-01-28 16:30 ` [PATCH 2/2] ARM: shmobile: Move shmobile_smp_{mpidr,fn,arg}[] " Nicolas Pitre
2016-01-28 15:19 ` [PATCH 0/2] ARM: shmobile: Move written variables " Kees Cook
2016-01-28 17:48 ` Russell King - ARM Linux
2016-01-28 19:07 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA35AF.8080601@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.