From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: "Nicholas A. Bellinger" <nab@daterainc.com>,
target-devel <target-devel@vger.kernel.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Quinn Tran <quinn.tran@qlogic.com>,
Himanshu Madhani <himanshu.madhani@qlogic.com>,
Sagi Grimberg <sagig@mellanox.com>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Andy Grover <agrover@redhat.com>,
Mike Christie <mchristi@redhat.com>,
Nicholas Bellinger <nab@linux-iscsi.org>
Subject: Re: [PATCH-v2 1/3] target: Fix LUN_RESET active I/O handling for ACK_KREF
Date: Thu, 28 Jan 2016 19:00:28 +0200 [thread overview]
Message-ID: <56AA492C.2080301@dev.mellanox.co.il> (raw)
In-Reply-To: <1453513067-23169-2-git-send-email-nab@daterainc.com>
> + sess = cmd->se_sess;
> + if (WARN_ON_ONCE(!sess))
> + continue;
> +
> + spin_lock(&sess->sess_cmd_lock);
> + rc = __target_check_io_state(cmd);
> + spin_unlock(&sess->sess_cmd_lock);
> + if (!rc) {
> + printk("LUN_RESET I/O: non-zero kref_get_unless_zero\n");
Is this message always correct? __target_check_io_state() will return
false for commands that were completed..
next prev parent reply other threads:[~2016-01-28 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 1:37 [PATCH-v2 0/3] target: Fix LUN_RESET active I/O + TMR handling Nicholas A. Bellinger
2016-01-23 1:37 ` [PATCH-v2 1/3] target: Fix LUN_RESET active I/O handling for ACK_KREF Nicholas A. Bellinger
2016-01-26 17:19 ` Christoph Hellwig
2016-01-28 5:34 ` Nicholas A. Bellinger
2016-01-28 17:00 ` Sagi Grimberg [this message]
2016-01-23 1:37 ` [PATCH-v2 2/3] target: Fix LUN_RESET active TMR descriptor handling Nicholas A. Bellinger
2016-01-26 17:21 ` Christoph Hellwig
2016-01-23 1:37 ` [PATCH-v2 3/3] target: Fix TAS handling for multi-session se_node_acls Nicholas A. Bellinger
2016-01-26 17:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA492C.2080301@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=agrover@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=himanshu.madhani@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=nab@daterainc.com \
--cc=nab@linux-iscsi.org \
--cc=quinn.tran@qlogic.com \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.