Re: [PATCH] add driver for DesignWare UFS Host Controller

[Joao Pinto <Joao.Pinto@synopsys.com>]

Hi Akinobu,

I managed to make the following replacement:
"lrbp->command_type = UTP_CMD_TYPE_DEV_MANAGE;" for
"lrbp->command_type = DWC_UTRD_CMD_TYPE_UFS_STORAGE;" being
DWC_UTRD_CMD_TYPE_UFS_STORAGE = 0x11

Now I get OCS = 0 which is good:
@0000 [0]:11000000
@0004 [1]:93936a6a
@0008 [2]:00000000
@000c [3]:93936a6a
@0010 [4]:9f317400
@0014 [5]:00000000
@0018 [6]:00800080
@001c [7]:01006a6a

But now the command is not completed time left is 0 in ufshcd_wait_for_dev_cmd()
and even after clearing the door bell the issue is not fixed. Did you ever have
this problem?

Joao

On 1/28/2016 5:00 PM, Joao Pinto wrote:
> Hi Akinobu,
> Thanks for the tip!
> 
> Joao
> 
> On 1/28/2016 12:35 PM, Akinobu Mita wrote:
>> Hi Joao,
>>
>> 2016-01-28 2:04 GMT+09:00 Joao Pinto <Joao.Pinto@synopsys.com>:
>>> - NOP_OUT is failing with OCS = 0x7
>>>
>>> The OCS value is calculated in ufshcd_get_tr_ocs() in ufshcd.c.
>>> I made a dump of the UTRD pointer where we can check the status = 7 ([2]).
>>>
>>> UTRD at: 7007c3e0
>>> @0000 [0]:21000000
>>> @0004 [1]:93936a6a
>>> @0008 [2]:00000007
>>> @000c [3]:93936a6a
>>> @0010 [4]:9f317400
>>> @0014 [5]:00000000
>>> @0018 [6]:00800080
>>> @001c [7]:01006a6a
>>>
>>> Did anyone have the same problem? Any hints to overcome this issue?
>>
>> I have seen similar problem when using UFS 2.0 controller.
>>
>> The ufs driver currently doesn't set correct command type field in
>> UTP transfer request descriptor (bit 31:28 in DW0) for UFS 2.0
>> controller.  I checked that your DesignWare UFS driver handles it
>> correctly, so please try with that change.
>>
>