From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH 22/31] media: dvb-core create tuner to demod pad link in disabled state Date: Thu, 28 Jan 2016 13:09:25 -0700 Message-ID: <56AA7575.804@osg.samsung.com> References: <753bb19d9d474ab419ad7ee37f7d30a1db6a8e35.1452105878.git.shuahkh@osg.samsung.com> <20160128143831.351a2e6c@recife.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160128143831.351a2e6c@recife.lan> Sender: linux-kernel-owner@vger.kernel.org To: Mauro Carvalho Chehab Cc: tiwai@suse.com, clemens@ladisch.de, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, javier@osg.samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, perex@perex.cz, arnd@arndb.de, dan.carpenter@oracle.com, tvboxspy@gmail.com, crope@iki.fi, ruchandani.tina@gmail.com, corbet@lwn.net, chehabrafael@gmail.com, k.kozlowski@samsung.com, stefanr@s5r6.in-berlin.de, inki.dae@samsung.com, jh1009.sung@samsung.com, elfring@users.sourceforge.net, prabhakar.csengg@gmail.com, sw0312.kim@samsung.com, p.zabel@pengutronix.de, ricardo.ribalda@gmail.com, labbott@fedoraproject.org, pierre-louis.bossart@linux.intel.com, ricard.wanderlof@axis.com, julian@jusst.de, takamichiho@gmail.com, dominic.sacre@gmx.de, misterpib@gmail.com, daniel@zonque.org, gtmkramer@xs4all.nl, normalperson@yhbt.net, joe@oampo.co.uk, linuxbugs@vittga List-Id: alsa-devel@alsa-project.org On 01/28/2016 09:38 AM, Mauro Carvalho Chehab wrote: > Em Wed, 6 Jan 2016 13:27:11 -0700 > Shuah Khan escreveu: > >> Create tuner to demod pad link in disabled state to help avoid >> disable step when tuner resource is requested by video or audio. >> >> Signed-off-by: Shuah Khan >> --- >> drivers/media/dvb-core/dvbdev.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c >> index b56e008..1d10fa6 100644 >> --- a/drivers/media/dvb-core/dvbdev.c >> +++ b/drivers/media/dvb-core/dvbdev.c >> @@ -593,8 +593,9 @@ int dvb_create_media_graph(struct dvb_adapter *adap) >> } >> >> if (tuner && demod) { >> + /* create tuner to demod link deactivated */ >> ret = media_create_pad_link(tuner, TUNER_PAD_IF_OUTPUT, >> - demod, 0, MEDIA_LNK_FL_ENABLED); >> + demod, 0, 0); > > This is not right, as it makes no sense for DVB-only drivers. Right. Not a good change for DVB only drivers. But does make sense on hybrid. I will make sure it gets done only in hyrbid cases. thanks, -- Shuah > >> if (ret) >> return ret; >> } -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lists.s-osg.org ([54.187.51.154]:59159 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754962AbcA1UJ3 (ORCPT ); Thu, 28 Jan 2016 15:09:29 -0500 Subject: Re: [PATCH 22/31] media: dvb-core create tuner to demod pad link in disabled state To: Mauro Carvalho Chehab References: <753bb19d9d474ab419ad7ee37f7d30a1db6a8e35.1452105878.git.shuahkh@osg.samsung.com> <20160128143831.351a2e6c@recife.lan> Cc: tiwai@suse.com, clemens@ladisch.de, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, javier@osg.samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, perex@perex.cz, arnd@arndb.de, dan.carpenter@oracle.com, tvboxspy@gmail.com, crope@iki.fi, ruchandani.tina@gmail.com, corbet@lwn.net, chehabrafael@gmail.com, k.kozlowski@samsung.com, stefanr@s5r6.in-berlin.de, inki.dae@samsung.com, jh1009.sung@samsung.com, elfring@users.sourceforge.net, prabhakar.csengg@gmail.com, sw0312.kim@samsung.com, p.zabel@pengutronix.de, ricardo.ribalda@gmail.com, labbott@fedoraproject.org, pierre-louis.bossart@linux.intel.com, ricard.wanderlof@axis.com, julian@jusst.de, takamichiho@gmail.com, dominic.sacre@gmx.de, misterpib@gmail.com, daniel@zonque.org, gtmkramer@xs4all.nl, normalperson@yhbt.net, joe@oampo.co.uk, linuxbugs@vittgam.net, johan@oljud.se, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-api@vger.kernel.org, alsa-devel@alsa-project.org, Shuah Khan From: Shuah Khan Message-ID: <56AA7575.804@osg.samsung.com> Date: Thu, 28 Jan 2016 13:09:25 -0700 MIME-Version: 1.0 In-Reply-To: <20160128143831.351a2e6c@recife.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 01/28/2016 09:38 AM, Mauro Carvalho Chehab wrote: > Em Wed, 6 Jan 2016 13:27:11 -0700 > Shuah Khan escreveu: > >> Create tuner to demod pad link in disabled state to help avoid >> disable step when tuner resource is requested by video or audio. >> >> Signed-off-by: Shuah Khan >> --- >> drivers/media/dvb-core/dvbdev.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c >> index b56e008..1d10fa6 100644 >> --- a/drivers/media/dvb-core/dvbdev.c >> +++ b/drivers/media/dvb-core/dvbdev.c >> @@ -593,8 +593,9 @@ int dvb_create_media_graph(struct dvb_adapter *adap) >> } >> >> if (tuner && demod) { >> + /* create tuner to demod link deactivated */ >> ret = media_create_pad_link(tuner, TUNER_PAD_IF_OUTPUT, >> - demod, 0, MEDIA_LNK_FL_ENABLED); >> + demod, 0, 0); > > This is not right, as it makes no sense for DVB-only drivers. Right. Not a good change for DVB only drivers. But does make sense on hybrid. I will make sure it gets done only in hyrbid cases. thanks, -- Shuah > >> if (ret) >> return ret; >> } -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978