From: Eric Blake <eblake@redhat.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
Thomas Huth <thuth@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 5/5] doc: Introduce coding style for errors
Date: Thu, 28 Jan 2016 15:01:59 -0700 [thread overview]
Message-ID: <56AA8FD7.3070300@redhat.com> (raw)
In-Reply-To: <145401803957.13643.4011946397351594395.stgit@localhost>
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
On 01/28/2016 02:53 PM, Lluís Vilanova wrote:
> Gives some general guidelines for reporting errors in QEMU.
>
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> HACKING | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
I'm not sure if my v4 review crossed paths with this, but I still see typos:
> +
> +WARNING: The special 'error_fatal' and 'error_abort' objects follow the same
> +constrains as the 'error_report_fatal' and 'error_report_abort' functions.
s/constrains/constraints/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-28 22:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 21:53 [Qemu-devel] [RFC][PATCH v5 0/5] utils: Improve and document error reporting Lluís Vilanova
2016-01-28 21:53 ` [Qemu-devel] [PATCH v5 1/5] util: Introduce error reporting functions with fatal/abort Lluís Vilanova
2016-01-28 21:53 ` [Qemu-devel] [PATCH v5 2/5] util: Use new error_report_fatal/abort instead of error_setg(&error_fatal/abort) Lluís Vilanova
2016-01-29 5:30 ` David Gibson
2016-01-29 13:33 ` Lluís Vilanova
2016-01-31 5:59 ` David Gibson
2016-01-28 21:53 ` [PATCH v5 3/5] util: [ppc] Use new error_report_fatal() instead of exit() Lluís Vilanova
2016-01-28 21:53 ` [Qemu-devel] " Lluís Vilanova
2016-01-28 21:53 ` [PATCH v5 4/5] util: [ppc] Use new error_report_abort() instead of abort() Lluís Vilanova
2016-01-28 21:53 ` [Qemu-devel] " Lluís Vilanova
2016-01-28 21:53 ` [Qemu-devel] [PATCH v5 5/5] doc: Introduce coding style for errors Lluís Vilanova
2016-01-28 22:01 ` Eric Blake [this message]
2016-01-29 13:33 ` Lluís Vilanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA8FD7.3070300@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=thuth@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.