Hi Andrew,

On 01/22/2016 08:59 PM, Andrew Zaborowski wrote:
> ---
>   ell/dbus-service.c      | 216 ++++++++++++++++++++++++++++++++++++++++++++++--
>   examples/dbus-service.c |  86 +------------------
>   2 files changed, 212 insertions(+), 90 deletions(-)
>

<snip>

> +static struct l_dbus_message *old_set_property(struct l_dbus *dbus,
> +						struct l_dbus_message *message,
> +						void *user_data)
> +{

<snip>

> +
> +	signature = property->metainfo + strlen(property->metainfo) + 1;
> +
> +	if (l_dbus_message_iter_get_type(&variant) != signature[0])
> +		return l_dbus_message_new_error(message,
> +						"org.freedesktop.DBus.Error."
> +						"InvalidArgs",
> +						"Expected type '%s'",
> +						signature);
> +

Is this check strictly needed?  The setter would be running a 
l_dbus_message_iter_get_variant call anyway which does a more thorough 
signature check.

Rest looks fine.

Regards,
-Denis