From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v7 0/2] Add Rockchip Inno-HDMI driver Date: Fri, 29 Jan 2016 09:49:55 +0800 Message-ID: <56AAC543.8080108@rock-chips.com> References: <1453777142-30119-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1453777142-30119-1-git-send-email-ykk@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yakir Yang , Heiko Stuebner Cc: Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Ben Chan , Ken Mixte , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , Thierry Reding , linux-arm-kernel@lists.infradead.org, Zheng Yang List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDAx5pyIMjbml6UgMTA6NTksIFlha2lyIFlhbmcgd3JvdGU6Cj4gSGVyZSBhcmUg YSBicmllZiBpbnRyb2R1Y3Rpb24gdG8gSW5ub3NpbGljb24gSERNSSBJUDoKPiAgICAtIFN1cHBv cnQgSERNSSAxLjRhLCBIRENQIDEuMiBhbmQgRFZJIDEuMCBzdGFuZGFyZCBjb21wbGlhbnQgdHJh bnNtaXR0ZXIKPiAgICAtIFN1cHBvcnQgSERNSTEuNCBhL2IgM0QgZnVuY3Rpb24gZGVmaW5lZCBp biBIRE1JIDEuNCBhL2Igc3BlYwo+ICAgIC0gRGlnaXRhbCB2aWRlbyBpbnRlcmZhY2Ugc3VwcG9y dHMgYSBwaXhlbCBzaXplIG9mIDI0LCAzMCwgMzYsIDQ4Yml0cyBjb2xvciBkZXB0aCBpbiBSR0IK PiAgICAtIFMvUERJRiBvdXRwdXQgc3VwcG9ydHMgUENNLCBEb2xieSBEaWdpdGFsLCBEVFMgZGln aXRhbCBhdWRpbyB0cmFuc21pc3Npb24KPiAgICAgICgzMi0xOTJrSHogRnMpIHVzaW5nIElFQzYw OTU4IGFuZCBJRUMgNjE5MzcKPiAgICAtIFRoZSBFRElEIGFuZCBDRUMgZnVuY3Rpb24gYXJlIGFs c28gc3VwcG9ydGVkIGJ5IElubm9zaWxpY29uIEhETUkgVHJhbnNtaXR0ZXIgQ29udHJvbGxlCj4K PiBDaGFuZ2VzIGluIHY3Ogo+IC0gQ29ycmVjdCB0aGUgbW9kdWxlIGxpY25lc2Ugc3RhdGVtZW50 IChQYXVsKQo+ICAgICAgIC0gTU9EVUxFX0xJQ0VOU0UoIkdQTCIpOwo+ICAgICAgICsgTU9EVUxF X0xJQ0VOU0UoIkdQTCB2MiIpOwo+IC0gU3RhcnQgaW5kZW50YXRpb24gd2l0aCB0YWJzIGFuZCBm aXggdGhlIG1pc3NwZWxsIGluIEtjb25maWcgKFBhdWwpCj4gLSBDYXJyeSB0aGUgbG9zdCBkZXZp Y2UtYmluZGluZyBkb2N1bWVudCAoSGVpa28pCj4KPiBDaGFuZ2VzIGluIHY2Ogo+IC0gUmViYXNl IHRoZSBNYWtlZmlsZS9LY29uZmlnIGZpbGVzIHdoaWNoIGFkZCBieSBDaHJpcydzIHJvY2tjaGlw LW1pcGkgZHJpdmVyIChDYWVzZXIpCj4KPiBDaGFuZ2VzIGluIHY1Ogo+IC0gVXNlIGhkbWlfaW5m b2ZyYW1lIGhlbHBlciBmdW5jdGlvbnMgdG8gcGFja2VkIHRoZSBpbmZvZnJhbWUgKFJ1c3NlbGwp Cj4gLSBSZW1vdmUgdGhlIHVudXNlZCBkb3VibGUgd2FpdF9mb3JfY29tcGxldGlvbl90aW1lb3V0 IGZvciBkZGMgdHJhbnNmZXIgKFJ1c3NlbGwpCj4gLSBSZW1vdmUgdGhlIHVudXNlZCBsb2NhbCB2 YXJpYWJsZSBpbiAiaW5ub19oZG1pX2kyY193cml0ZSgpIiBmdW5jdGlvbiAoUnVzc2VsbCkKPgo+ IENoYW5nZXMgaW4gdjQ6Cj4gLSBNb2RpZnkgdGhlIGNvbW1pdCB0aXRsZSAiZHJtL3JvY2tjaGlw OiBoZG1pOiAuLi4iIChNYXJrKQo+IC0gQ29ycmVjdCB0aGUgIkRLTVMiIHRvICJEUE1TIiAoTWFy aykKPiAtIEZpeCBvdmVyIDgwIGNoYXJhY3RlcnMgcHJvYmxlbXMgKE1hcmspCj4gLSBSZW1vdmUg ZW5jb2RlciAucHJlcGFyZS8uY29tbWl0IGhlbHBlciBmdW5jdGlvbnMsIGFuZCBtb3ZlIHRoZSB2 b3AgbW9kZQo+IGNvbmZpZ3VyZSBmdW5jdGlvbiBpbnRvIGVuY29kZXIgLmVuYWJsZSBoZWxwZXIg ZnVuY3Rpb25zLiAoTWFyaykKPgo+IENoYW5nZXMgaW4gdjM6Cj4gLSBVc2UgZW5jb2RlciBlbmFi bGUvZGlzYWJsZSBmdW5jdGlvbiwgYW5kIHJlbW92ZSB0aGUgZW5jb2RlciBEUE1TIGZ1bmN0aW9u Cj4gLSBLZWVwIEhETUkgUExMIHBvd2VyIG9uIGluIHN0YW5kYnkgbW9kZQo+Cj4gQ2hhbmdlcyBp biB2MjoKPiAtIFVzaW5nIERSTSBhdG9taWMgaGVscGVyIGZ1bmN0aW9ucyBmb3IgY29ubmVjdG9y IGluaXQgKE1hcmspCj4gLSBSZW1vdmUgImhkbWktPmNvbm5lY3Rvci5lbmNvZGVyID0gZW5jb2Rl cjsiIChNYXJrKQo+IC0gQWRkIHRoZSBBY2tlZC1ieSB0YWdzIGZyb20gUm9iCj4gLSBDb3JyZWN0 IHRoZSBtaXNzcGVsbCAicmszMDM2LWR3LWhkbWkiIChIZWlrbykKPgo+IFlha2lyIFlhbmcgKDIp Ogo+ICAgIGRybS9yb2NrY2hpcDogaGRtaTogYWRkIElubm9zaWxpY29uIEhETUkgc3VwcG9ydAo+ ICAgIGR0LWJpbmRpbmdzOiBhZGQgZG9jdW1lbnQgZm9yIElubm9zaWxpY29uIEhETUkgb24gUm9j a2NoaXAgcGxhdGZvcm0KPgo+ICAgLi4uL2Rpc3BsYXkvcm9ja2NoaXAvaW5ub19oZG1pLXJvY2tj aGlwLnR4dCAgICAgICAgfCAgNTAgKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29u ZmlnICAgICAgICAgICAgICAgICAgIHwgICA4ICsKPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hp cC9NYWtlZmlsZSAgICAgICAgICAgICAgICAgIHwgICAxICsKPiAgIGRyaXZlcnMvZ3B1L2RybS9y b2NrY2hpcC9pbm5vX2hkbWkuYyAgICAgICAgICAgICAgIHwgOTQxICsrKysrKysrKysrKysrKysr KysrKwo+ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2lubm9faGRtaS5oICAgICAgICAgICAg ICAgfCAzNjIgKysrKysrKysKPiAgIDUgZmlsZXMgY2hhbmdlZCwgMTM2MiBpbnNlcnRpb25zKCsp Cj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2Rpc3BsYXkvcm9ja2NoaXAvaW5ub19oZG1pLXJvY2tjaGlwLnR4dAo+ICAgY3JlYXRlIG1vZGUg MTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9pbm5vX2hkbWkuYwo+ICAgY3JlYXRlIG1v ZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9pbm5vX2hkbWkuaAo+CgpQaW5nLCBp bm5vIEhETUkgZHJpdmVyIGxvb2tzIGdvb2QgZm9yIG1lLCBhbmQgaXQgd29ya3MsIFNvIEknZCBs aWtlIHRvIAptZXJnZSBpdCBpbnRvIGRybS9yb2NrY2hpcCBpZiB0aGVyZSBpcyBubyBkb3VidCB0 aGVzZSBkYXlzLgoKVGhhbmtzLgoKLS0gCu+8rWFyayBZYW8KCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Fri, 29 Jan 2016 09:49:55 +0800 Subject: [PATCH v7 0/2] Add Rockchip Inno-HDMI driver In-Reply-To: <1453777142-30119-1-git-send-email-ykk@rock-chips.com> References: <1453777142-30119-1-git-send-email-ykk@rock-chips.com> Message-ID: <56AAC543.8080108@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?01?26? 10:59, Yakir Yang wrote: > Here are a brief introduction to Innosilicon HDMI IP: > - Support HDMI 1.4a, HDCP 1.2 and DVI 1.0 standard compliant transmitter > - Support HDMI1.4 a/b 3D function defined in HDMI 1.4 a/b spec > - Digital video interface supports a pixel size of 24, 30, 36, 48bits color depth in RGB > - S/PDIF output supports PCM, Dolby Digital, DTS digital audio transmission > (32-192kHz Fs) using IEC60958 and IEC 61937 > - The EDID and CEC function are also supported by Innosilicon HDMI Transmitter Controlle > > Changes in v7: > - Correct the module licnese statement (Paul) > - MODULE_LICENSE("GPL"); > + MODULE_LICENSE("GPL v2"); > - Start indentation with tabs and fix the misspell in Kconfig (Paul) > - Carry the lost device-binding document (Heiko) > > Changes in v6: > - Rebase the Makefile/Kconfig files which add by Chris's rockchip-mipi driver (Caeser) > > Changes in v5: > - Use hdmi_infoframe helper functions to packed the infoframe (Russell) > - Remove the unused double wait_for_completion_timeout for ddc transfer (Russell) > - Remove the unused local variable in "inno_hdmi_i2c_write()" function (Russell) > > Changes in v4: > - Modify the commit title "drm/rockchip: hdmi: ..." (Mark) > - Correct the "DKMS" to "DPMS" (Mark) > - Fix over 80 characters problems (Mark) > - Remove encoder .prepare/.commit helper functions, and move the vop mode > configure function into encoder .enable helper functions. (Mark) > > Changes in v3: > - Use encoder enable/disable function, and remove the encoder DPMS function > - Keep HDMI PLL power on in standby mode > > Changes in v2: > - Using DRM atomic helper functions for connector init (Mark) > - Remove "hdmi->connector.encoder = encoder;" (Mark) > - Add the Acked-by tags from Rob > - Correct the misspell "rk3036-dw-hdmi" (Heiko) > > Yakir Yang (2): > drm/rockchip: hdmi: add Innosilicon HDMI support > dt-bindings: add document for Innosilicon HDMI on Rockchip platform > > .../display/rockchip/inno_hdmi-rockchip.txt | 50 ++ > drivers/gpu/drm/rockchip/Kconfig | 8 + > drivers/gpu/drm/rockchip/Makefile | 1 + > drivers/gpu/drm/rockchip/inno_hdmi.c | 941 +++++++++++++++++++++ > drivers/gpu/drm/rockchip/inno_hdmi.h | 362 ++++++++ > 5 files changed, 1362 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt > create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.c > create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.h > Ping, inno HDMI driver looks good for me, and it works, So I'd like to merge it into drm/rockchip if there is no doubt these days. Thanks. -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754968AbcA2BuN (ORCPT ); Thu, 28 Jan 2016 20:50:13 -0500 Received: from regular1.263xmail.com ([211.150.99.130]:53687 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754271AbcA2BuK (ORCPT ); Thu, 28 Jan 2016 20:50:10 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <6a2e877f27a6528f8d2a984651fa543e> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56AAC543.8080108@rock-chips.com> Date: Fri, 29 Jan 2016 09:49:55 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Yakir Yang , Heiko Stuebner CC: David Airlie , Thierry Reding , Rob Herring , Ken Mixte , Ben Chan , Zheng Yang , Kumar Gala , Ian Campbell , Pawel Moll , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 0/2] Add Rockchip Inno-HDMI driver References: <1453777142-30119-1-git-send-email-ykk@rock-chips.com> In-Reply-To: <1453777142-30119-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年01月26日 10:59, Yakir Yang wrote: > Here are a brief introduction to Innosilicon HDMI IP: > - Support HDMI 1.4a, HDCP 1.2 and DVI 1.0 standard compliant transmitter > - Support HDMI1.4 a/b 3D function defined in HDMI 1.4 a/b spec > - Digital video interface supports a pixel size of 24, 30, 36, 48bits color depth in RGB > - S/PDIF output supports PCM, Dolby Digital, DTS digital audio transmission > (32-192kHz Fs) using IEC60958 and IEC 61937 > - The EDID and CEC function are also supported by Innosilicon HDMI Transmitter Controlle > > Changes in v7: > - Correct the module licnese statement (Paul) > - MODULE_LICENSE("GPL"); > + MODULE_LICENSE("GPL v2"); > - Start indentation with tabs and fix the misspell in Kconfig (Paul) > - Carry the lost device-binding document (Heiko) > > Changes in v6: > - Rebase the Makefile/Kconfig files which add by Chris's rockchip-mipi driver (Caeser) > > Changes in v5: > - Use hdmi_infoframe helper functions to packed the infoframe (Russell) > - Remove the unused double wait_for_completion_timeout for ddc transfer (Russell) > - Remove the unused local variable in "inno_hdmi_i2c_write()" function (Russell) > > Changes in v4: > - Modify the commit title "drm/rockchip: hdmi: ..." (Mark) > - Correct the "DKMS" to "DPMS" (Mark) > - Fix over 80 characters problems (Mark) > - Remove encoder .prepare/.commit helper functions, and move the vop mode > configure function into encoder .enable helper functions. (Mark) > > Changes in v3: > - Use encoder enable/disable function, and remove the encoder DPMS function > - Keep HDMI PLL power on in standby mode > > Changes in v2: > - Using DRM atomic helper functions for connector init (Mark) > - Remove "hdmi->connector.encoder = encoder;" (Mark) > - Add the Acked-by tags from Rob > - Correct the misspell "rk3036-dw-hdmi" (Heiko) > > Yakir Yang (2): > drm/rockchip: hdmi: add Innosilicon HDMI support > dt-bindings: add document for Innosilicon HDMI on Rockchip platform > > .../display/rockchip/inno_hdmi-rockchip.txt | 50 ++ > drivers/gpu/drm/rockchip/Kconfig | 8 + > drivers/gpu/drm/rockchip/Makefile | 1 + > drivers/gpu/drm/rockchip/inno_hdmi.c | 941 +++++++++++++++++++++ > drivers/gpu/drm/rockchip/inno_hdmi.h | 362 ++++++++ > 5 files changed, 1362 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt > create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.c > create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.h > Ping, inno HDMI driver looks good for me, and it works, So I'd like to merge it into drm/rockchip if there is no doubt these days. Thanks. -- Ｍark Yao