From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wan Zongshun Subject: Re: [Patch v3 11/12] iommu/amd: No need to wait iommu completion if no dte irq entry change Date: Fri, 29 Jan 2016 10:57:57 +0800 Message-ID: <56AAD535.6090600@iommu.org> References: <1453804166-25646-1-git-send-email-bhe@redhat.com> <1453804166-25646-12-git-send-email-bhe@redhat.com> <56A8A3EC.7090701@iommu.org> <20160128102401.GE3851@x1.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160128102401.GE3851-ejN7fcUYdH/by3iVrkZq2A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Baoquan He Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Ray Huang List-Id: iommu@lists.linux-foundation.org -------- Original Message -------- > On 01/27/16 at 07:03pm, Wan Zongshun wrote: >> >> >> -------- Original Message -------- >>> >>> alias = amd_iommu_alias_table[devid]; >>> table = irq_lookup_table[alias]; >>> @@ -3688,7 +3688,7 @@ static struct irq_remap_table *get_irq_table(u16 devid, bool ioapic) >>> /* Nothing there yet, allocate new irq remapping table */ >>> table = kzalloc(sizeof(*table), GFP_ATOMIC); >>> if (!table) >>> - goto out; >>> + goto out_unlock; >>> >>> /* Initialize table spin-lock */ >>> spin_lock_init(&table->lock); >>> @@ -3701,7 +3701,7 @@ static struct irq_remap_table *get_irq_table(u16 devid, bool ioapic) >>> if (!table->table) { >>> kfree(table); >>> table = NULL; >>> - goto out; >>> + goto out_unlock; >>> } >>> >>> memset(table->table, 0, MAX_IRQS_PER_TABLE * sizeof(u32)); >>> >> >> So here the 'out:' label text should also remove, since no err need >> goto it, right? >> >> out: >> iommu_completion_wait(iommu); > > Seems we still need out lable here since it need jump to out label if > alias irte table has been set ite irte table of alias will be set in DTE. > It is okay. > > >