From: 郑阳 <yang.zheng@rock-chips.com>
To: Yakir Yang <ykk@rock-chips.com>,
Mark Yao <mark.yao@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Ken Mixte <kmixter@google.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Thierry Reding <treding@nvidia.com>,
linux-arm-kernel@lists.infradead.org,
Ben Chan <benchan@google.com>
Subject: Re: [PATCH v2 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support
Date: Fri, 29 Jan 2016 14:17:10 +0800 [thread overview]
Message-ID: <56AB03E6.6020107@rock-chips.com> (raw)
In-Reply-To: <1452161024-27198-1-git-send-email-ykk@rock-chips.com>
[-- Attachment #1.1: Type: text/plain, Size: 1461 bytes --]
在 2016年01月07日 18:03, Yakir Yang 写道:
> diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
> new file mode 100644
> index 0000000..9327617
> --- /dev/null
> +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
>
> +static int inno_hdmi_config_video_avi(struct inno_hdmi *hdmi)
> +{
> +
> + if (hdmi->hdmi_data.enc_out_format == HDMI_COLORSPACE_RGB) +
> avi_color_mode = AVI_COLOR_MODE_RGB;
> + else if (hdmi->hdmi_data.enc_out_format == HDMI_COLORSPACE_YUV444)
> + avi_color_mode = AVI_COLOR_MODE_YCBCR444;
> + else if (hdmi->hdmi_data.enc_out_format == HDMI_COLORSPACE_YUV422)
> + avi_color_mode = AVI_COLOR_MODE_YCBCR422;
> + else
> + avi_color_mode = AVI_COLOR_MODE_RGB;
> +
Fist if is no need, its result is same to "else".
> +static int inno_hdmi_config_video_csc(struct inno_hdmi *hdmi)
> +{
>
> + if (data->enc_out_format == data->enc_out_format) {
> + if ((data->enc_in_format == HDMI_COLORSPACE_RGB) ||
> + (data->enc_in_format >= HDMI_COLORSPACE_YUV444)) {
> + value = v_SOF_DISABLE | v_COLOR_DEPTH_NOT_INDICATED(1);
> + hdmi_writeb(hdmi, HDMI_VIDEO_CONTRL3, value);
> +
> + hdmi_modb(hdmi, HDMI_VIDEO_CONTRL,
> + m_VIDEO_AUTO_CSC | m_VIDEO_C0_C2_SWAP,
> + v_VIDEO_AUTO_CSC(AUTO_CSC_DISABLE) |
> + v_VIDEO_C0_C2_SWAP(C0_C2_CHANGE_DISABLE));
> + return 0;
> + }
> + }
>
It seems should be if (data->enc_in_format == data->enc_out_format).
[-- Attachment #1.2: Type: text/html, Size: 2086 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-29 6:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 10:01 [PATCH v2 0/2] Introduce Innosilicon HDMI driver on Rockchip platforms Yakir Yang
2016-01-07 10:01 ` Yakir Yang
2016-01-07 10:01 ` Yakir Yang
2016-01-07 10:03 ` [PATCH v2 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support Yakir Yang
2016-01-07 10:03 ` Yakir Yang
2016-01-07 10:03 ` Yakir Yang
2016-01-29 6:17 ` 郑阳 [this message]
2016-01-29 6:31 ` Yakir Yang
2016-01-07 10:07 ` [PATCH v2 2/2] dt-bindings: add document for Innosilicon HDMI on Rockchip platform Yakir Yang
2016-01-07 10:07 ` Yakir Yang
2016-01-07 10:07 ` Yakir Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AB03E6.6020107@rock-chips.com \
--to=yang.zheng@rock-chips.com \
--cc=benchan@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kmixter@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mark.yao@rock-chips.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=treding@nvidia.com \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.